From: Darren Hart <dvhart@infradead.org>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Andrei Borzenkov <arvidjaar@gmail.com>,
Gabriele Mazzotta <gabriele.mzt@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"D. Jared Dominguez" <Jared_Dominguez@dell.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
Alex Hung <alex.hung@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended
Date: Tue, 24 May 2016 12:57:26 -0700 [thread overview]
Message-ID: <20160524195726.GM2735@f23x64.localdomain> (raw)
In-Reply-To: <20160524070938.GG29844@pali>
On Tue, May 24, 2016 at 09:09:38AM +0200, Pali Rohár wrote:
> On Tuesday 24 May 2016 06:48:41 Andrei Borzenkov wrote:
> > 24.05.2016 02:03, Gabriele Mazzotta пишет:
> > > On 24/05/2016 00:22, Pali Rohár wrote:
...
> > > +#ifdef CONFIG_PM_SLEEP
> > > +static void ACPI_SYSTEM_XFACE rbtn_acpi_clear_flag(void *context)
>
> I would rename this function to rbtn_clear_suspended_flag.
>
...
> > > + /*
> > > + * Upon resume, some BIOSes autonomously send an ACPI notification
You can drop "autonomously", it reads a bit awkwardly, and doesn't add any
information.
> > > + * that triggers an unwanted input event. In order to ignore it,
> > > + * we use a flag that we set at suspend and clear once we have
> > > + * received the extra notification. Since ACPI notifications are
> > > + * delivered asynchronously to drivers, we clear the flag from the
> > > + * workqueue used to deliver the notifications. This should be enough
> > > + * to guarantee that the flag is cleared only after we received the
> > > + * extra notification, if any.
> > > + */
> >
> > "guarantee" is rather strong word here. We really do not know anything
> > how and when these notifications are generated by firmware, so can only
> > hope. But otherwise this explains what this patch intends to do (so that
> > even me finally understood it :)
>
> Yes, thats better.
>
> > > + status = acpi_os_execute(OSL_NOTIFY_HANDLER,
> > > + rbtn_acpi_clear_flag, rbtn_data);
> > > + if (ACPI_FAILURE(status))
> > > + rbtn_data->suspended = false;
>
> And here rbtn_clear_suspended_flag(rbtn_data) call instead direct
> assignment.
>
I'm dropping this from the queue, and awaiting an updated version with the
requested changes (these from Pali, and the issue raised about "guarantee" being
too strong).
Thanks,
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2016-05-24 19:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 23:49 [PATCH v2] dell-rbtn: Ignore ACPI notifications if device is suspended Gabriele Mazzotta
2016-03-14 7:55 ` Alex Hung
2016-03-14 11:34 ` Gabriele Mazzotta
2016-03-14 11:45 ` Pali Rohár
2016-03-14 12:15 ` Andrei Borzenkov
2016-03-18 15:57 ` Andrei Borzenkov
2016-04-18 12:31 ` Pali Rohár
2016-03-18 22:44 ` [PATCH v3] " Gabriele Mazzotta
2016-03-21 12:17 ` Pali Rohár
2016-03-21 15:13 ` Gabriele Mazzotta
2016-03-24 9:39 ` Pali Rohár
2016-03-24 11:24 ` Gabriele Mazzotta
2016-03-28 17:33 ` Darren Hart
2016-03-28 17:58 ` Gabriele Mazzotta
2016-03-28 18:56 ` Darren Hart
2016-03-28 19:41 ` Gabriele Mazzotta
2016-03-29 5:24 ` Darren Hart
2016-03-29 11:13 ` Gabriele Mazzotta
2016-03-29 13:11 ` Rafael J. Wysocki
2016-04-18 12:35 ` Pali Rohár
2016-04-25 20:06 ` Gabriele Mazzotta
2016-05-19 13:30 ` Pali Rohár
2016-05-19 20:18 ` Darren Hart
2016-05-23 21:26 ` Darren Hart
2016-05-23 22:06 ` Pali Rohár
2016-05-23 22:17 ` Darren Hart
2016-05-23 22:22 ` Pali Rohár
2016-05-23 23:03 ` Gabriele Mazzotta
2016-05-24 3:48 ` Andrei Borzenkov
2016-05-24 7:09 ` Pali Rohár
2016-05-24 19:57 ` Darren Hart [this message]
2016-05-24 20:53 ` [PATCH v4] " Gabriele Mazzotta
2016-05-25 20:28 ` Darren Hart
2016-05-25 20:36 ` Pali Rohár
2016-05-25 20:47 ` Gabriele Mazzotta
2016-05-25 21:20 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524195726.GM2735@f23x64.localdomain \
--to=dvhart@infradead.org \
--cc=Jared_Dominguez@dell.com \
--cc=alex.hung@canonical.com \
--cc=arvidjaar@gmail.com \
--cc=gabriele.mzt@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).