From: Andrei Borzenkov <arvidjaar@gmail.com>
To: "Pali Rohár" <pali.rohar@gmail.com>,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "D. Jared Dominguez" <Jared_Dominguez@dell.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
Alex Hung <alex.hung@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] dell-rbtn: Ignore ACPI notifications if device is suspended
Date: Fri, 18 Mar 2016 18:57:33 +0300 [thread overview]
Message-ID: <56EC256D.9000004@gmail.com> (raw)
In-Reply-To: <20160314114525.GK8413@pali>
14.03.2016 14:45, Pali Rohár пишет:
> On Monday 14 March 2016 12:34:31 Gabriele Mazzotta wrote:
>> 2016-03-12 0:49 GMT+01:00 Gabriele Mazzotta <gabriele.mzt@gmail.com>:
>>> Some BIOSes unconditionally send an ACPI notification to RBTN when the
>>> system is resuming from suspend. This makes dell-rbtn send an input
>>> event to userspace as if a function key was pressed. Prevent this by
>>> ignoring all the notifications received while the device is suspended.
>>>
>>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=106031
>>> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
>>> ---
>>> drivers/platform/x86/dell-rbtn.c | 41 ++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 41 insertions(+)
>>>
>>> diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c
>>> index cd410e3..56b0da7 100644
>>> --- a/drivers/platform/x86/dell-rbtn.c
>>> +++ b/drivers/platform/x86/dell-rbtn.c
>>> @@ -28,6 +28,7 @@ struct rbtn_data {
>>> enum rbtn_type type;
>>> struct rfkill *rfkill;
>>> struct input_dev *input_dev;
>>> + bool suspended;
>>> };
>>>
>>>
>>> @@ -220,9 +221,44 @@ static const struct acpi_device_id rbtn_ids[] = {
>>> { "", 0 },
>>> };
>>>
>>> +#ifdef CONFIG_PM_SLEEP
>>> +static void ACPI_SYSTEM_XFACE rbtn_acpi_clear_flag(void *context)
>>> +{
>>> + struct rbtn_data *rbtn_data = context;
>>> +
>>> + rbtn_data->suspended = false;
>>> +}
>>> +
>>> +static int rbtn_suspend(struct device *dev)
>>> +{
>>> + struct acpi_device *device = to_acpi_device(dev);
>>> + struct rbtn_data *rbtn_data = acpi_driver_data(device);
>>> +
>>> + rbtn_data->suspended = true;
>>> +
>>> + return 0;
>>> +}
>>> +
>>> +static int rbtn_resume(struct device *dev)
>>> +{
>>> + struct acpi_device *device = to_acpi_device(dev);
>>> + struct rbtn_data *rbtn_data = acpi_driver_data(device);
>>> + acpi_status status;
>>> +
>>> + status = acpi_os_execute(OSL_NOTIFY_HANDLER,
>>> + rbtn_acpi_clear_flag, rbtn_data);
>>> + if (ACPI_FAILURE(status))
>>> + rbtn_data->suspended = false;
>>> +
>>> + return 0;
>>> +}
>>> +#endif
>>> +static SIMPLE_DEV_PM_OPS(rbtn_pm_ops, rbtn_suspend, rbtn_resume);
>>> +
>>> static struct acpi_driver rbtn_driver = {
>>> .name = "dell-rbtn",
>>> .ids = rbtn_ids,
>>> + .drv.pm = &rbtn_pm_ops,
>>> .ops = {
>>> .add = rbtn_add,
>>> .remove = rbtn_remove,
>>> @@ -384,6 +420,11 @@ static void rbtn_notify(struct acpi_device *device, u32 event)
>>> {
>>> struct rbtn_data *rbtn_data = device->driver_data;
>>>
>>> + if (rbtn_data->suspended) {
>>> + dev_dbg(&device->dev, "ACPI notification ignored\n");
>>> + return;
>>> + }
>>> +
>>> if (event != 0x80) {
>>> dev_info(&device->dev, "Received unknown event (0x%x)\n",
>>> event);
>>> --
>>> 2.7.0
>>>
>>
>> I'm sorry, Pali, I must have missed your email address while sending
>> this updated version.
>
> For me patch looks OK. I would suggest to add some comment about BIOS
> into code too.
>
> Rafael, can you review that ACPI suspended/OSL_NOTIFY_HANDLER part?
>
> Andrei, can you test if it now really fix it on your machine?
>
TBH I'm still unsure if this fixes root cause or just decreases race
window, but so far after multiple suspend/resume cycles on my Dell
Latitude E5450 WiFi was restored every time. So
Tested-By: Andrei Borzenkov <arvidjaar@gmail.com>
next prev parent reply other threads:[~2016-03-18 15:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 23:49 [PATCH v2] dell-rbtn: Ignore ACPI notifications if device is suspended Gabriele Mazzotta
2016-03-14 7:55 ` Alex Hung
2016-03-14 11:34 ` Gabriele Mazzotta
2016-03-14 11:45 ` Pali Rohár
2016-03-14 12:15 ` Andrei Borzenkov
2016-03-18 15:57 ` Andrei Borzenkov [this message]
2016-04-18 12:31 ` Pali Rohár
2016-03-18 22:44 ` [PATCH v3] " Gabriele Mazzotta
2016-03-21 12:17 ` Pali Rohár
2016-03-21 15:13 ` Gabriele Mazzotta
2016-03-24 9:39 ` Pali Rohár
2016-03-24 11:24 ` Gabriele Mazzotta
2016-03-28 17:33 ` Darren Hart
2016-03-28 17:58 ` Gabriele Mazzotta
2016-03-28 18:56 ` Darren Hart
2016-03-28 19:41 ` Gabriele Mazzotta
2016-03-29 5:24 ` Darren Hart
2016-03-29 11:13 ` Gabriele Mazzotta
2016-03-29 13:11 ` Rafael J. Wysocki
2016-04-18 12:35 ` Pali Rohár
2016-04-25 20:06 ` Gabriele Mazzotta
2016-05-19 13:30 ` Pali Rohár
2016-05-19 20:18 ` Darren Hart
2016-05-23 21:26 ` Darren Hart
2016-05-23 22:06 ` Pali Rohár
2016-05-23 22:17 ` Darren Hart
2016-05-23 22:22 ` Pali Rohár
2016-05-23 23:03 ` Gabriele Mazzotta
2016-05-24 3:48 ` Andrei Borzenkov
2016-05-24 7:09 ` Pali Rohár
2016-05-24 19:57 ` Darren Hart
2016-05-24 20:53 ` [PATCH v4] " Gabriele Mazzotta
2016-05-25 20:28 ` Darren Hart
2016-05-25 20:36 ` Pali Rohár
2016-05-25 20:47 ` Gabriele Mazzotta
2016-05-25 21:20 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EC256D.9000004@gmail.com \
--to=arvidjaar@gmail.com \
--cc=Jared_Dominguez@dell.com \
--cc=alex.hung@canonical.com \
--cc=gabriele.mzt@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).