From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
jh80.chung@sungmsung.com, Chanwoo Choi <cw00.choi@samsung.com>,
Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path with smack enabled environment
Date: Fri, 27 May 2016 20:26:05 +0100 [thread overview]
Message-ID: <20160527192605.GQ14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFx8J1sTuWjb9N9n7=WbHtr-aBEdWbb5qaf=rd598aUYHA@mail.gmail.com>
On Fri, May 27, 2016 at 12:01:05PM -0700, Linus Torvalds wrote:
> Al, if you want Casey to help test, I think you should write out the
> full git repository address, rather than just say "See
> vfs.git#smack-fix".
>
> Anybody who isn't used to pulling for you will just wonder where you
> keep your tree. And even I, who _am_ used to pulling from you, would
> have to look it up, so it's a lot more convenient if you actually
> write out the whole thing,
Point taken.
> Casey, Al is talking about
>
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs smack-fix
>
> and Al, please make your commit messages more informative than just
> "switch ->setxattr() to passing dentry and inode separately". You can
> see that from the patch. Please add a _why_ something is done, not
> just what it does.
Umm... Would something along the lines of
switch ->setxattr() to passing inode and dentry separately
smack ->d_instantiate() uses ->setxattr(), so to be able to call it before
we'd hashed the new dentry and attached it to inode, we ->setxattr() instances
get the inode as an explicit argument rather than obtaining it from dentry.
Similar change for ->getxattr() had been done commit ce23e64. Unlike
->getxattr() (which is used both by selinux and smack instances of
->d_instantiate()) ->setxattr() is used only by smack one and unfortunately
it had been missed back then.
be detailed enough for the second one with
switch xattr_handler->set() to passing inode and dentry separately
preparation for similar switch in ->setxattr() (see the next commit for
rationale)
for the first one?
next prev parent reply other threads:[~2016-05-27 19:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 11:09 [BUG] Panic when systemd boot do mkdir on tmpfs mounted path with smack enabled environment Seung-Woo Kim
2016-05-27 15:11 ` Al Viro
2016-05-27 18:51 ` Al Viro
2016-05-27 19:01 ` Linus Torvalds
2016-05-27 19:26 ` Al Viro [this message]
2016-05-27 19:34 ` Linus Torvalds
2016-05-27 19:43 ` Al Viro
2016-05-27 19:48 ` Linus Torvalds
2016-05-27 20:24 ` Al Viro
2016-05-27 22:44 ` Casey Schaufler
2016-05-30 1:43 ` Seung-Woo Kim
2016-05-27 19:03 ` Casey Schaufler
2016-05-27 19:37 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527192605.GQ14480@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=casey@schaufler-ca.com \
--cc=cw00.choi@samsung.com \
--cc=jh80.chung@sungmsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).