From: Linus Torvalds <torvalds@linux-foundation.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
jh80.chung@sungmsung.com, Chanwoo Choi <cw00.choi@samsung.com>,
Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [BUG] Panic when systemd boot do mkdir on tmpfs mounted path with smack enabled environment
Date: Fri, 27 May 2016 12:01:05 -0700 [thread overview]
Message-ID: <CA+55aFx8J1sTuWjb9N9n7=WbHtr-aBEdWbb5qaf=rd598aUYHA@mail.gmail.com> (raw)
In-Reply-To: <20160527185150.GP14480@ZenIV.linux.org.uk>
On Fri, May 27, 2016 at 11:51 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Fri, May 27, 2016 at 04:11:41PM +0100, Al Viro wrote:
>> There is a fairly straightforward way to handle that - do to ->setxattr()
>> what we'd already done to ->getxattr(). See vfs.git#smack-fix. Warning:
>> it's only build-tested. I'm going to have it go through LTP and xfstests
>> shortly; _please_ check if it works on your setup, because I've no idea
>> how to put together a testing setup for smack.
>
> FWIW, that couple of commits seems to survive the testing here and is
> pretty obvious. I have _NOT_ tested it on smack setups, so I really want
> somebody (Casey or someone in Samsung) to check if it fixes the problem.
> The change itself isn't tricky, but I fucking _hate_ doing that this late
> in the merge window ;-/
Al, if you want Casey to help test, I think you should write out the
full git repository address, rather than just say "See
vfs.git#smack-fix".
Anybody who isn't used to pulling for you will just wonder where you
keep your tree. And even I, who _am_ used to pulling from you, would
have to look it up, so it's a lot more convenient if you actually
write out the whole thing,
Casey, Al is talking about
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs smack-fix
and Al, please make your commit messages more informative than just
"switch ->setxattr() to passing dentry and inode separately". You can
see that from the patch. Please add a _why_ something is done, not
just what it does.
Linus
next prev parent reply other threads:[~2016-05-27 19:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 11:09 [BUG] Panic when systemd boot do mkdir on tmpfs mounted path with smack enabled environment Seung-Woo Kim
2016-05-27 15:11 ` Al Viro
2016-05-27 18:51 ` Al Viro
2016-05-27 19:01 ` Linus Torvalds [this message]
2016-05-27 19:26 ` Al Viro
2016-05-27 19:34 ` Linus Torvalds
2016-05-27 19:43 ` Al Viro
2016-05-27 19:48 ` Linus Torvalds
2016-05-27 20:24 ` Al Viro
2016-05-27 22:44 ` Casey Schaufler
2016-05-30 1:43 ` Seung-Woo Kim
2016-05-27 19:03 ` Casey Schaufler
2016-05-27 19:37 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFx8J1sTuWjb9N9n7=WbHtr-aBEdWbb5qaf=rd598aUYHA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=casey@schaufler-ca.com \
--cc=cw00.choi@samsung.com \
--cc=jh80.chung@sungmsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).