From: Mel Gorman <mgorman@techsingularity.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
linux-m68k <linux-m68k@vger.kernel.org>
Subject: Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm, page_alloc: avoid looking up the first zone in a zonelist twice)
Date: Mon, 30 May 2016 16:56:45 +0100 [thread overview]
Message-ID: <20160530155644.GP2527@techsingularity.net> (raw)
In-Reply-To: <CAMuHMdV00vJJxoA7XABw+mFF+2QUd1MuQbPKKgkmGnK_NySZpg@mail.gmail.com>
On Mon, May 30, 2016 at 03:13:40PM +0200, Geert Uytterhoeven wrote:
> > The benefit is negligible and the results are within the noise but each
> > cycle counts.
> >
> > Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
> > Cc: Vlastimil Babka <vbabka@suse.cz>
> > Cc: Jesper Dangaard Brouer <brouer@redhat.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>
> About one week ago, I started seeing an obscure intermittent crash during
> system shutdown on m68k/ARAnyM using atari_defconfig.
> The crash isn't 100% reproducible, but it happens during ca. 1 out of 5
> shutdowns.
>
> I finally managed to bisect it to the above commit.
> I did verify that the parent commit didn't crash after 60 tries.
> Unfortunately I couldn't revert the offending commit on top of v4.7-rc1, due to
> conflicting changes.
>
> Do you have any idea what's going wrong?
There isn't anything obvious from the crash log you showed but can you
try the following just in case?
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index dba8cfd0b2d6..f2c1e47adc11 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3232,6 +3232,9 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order,
* allocations are system rather than user orientated
*/
ac->zonelist = node_zonelist(numa_node_id(), gfp_mask);
+ ac->preferred_zoneref = first_zones_zonelist(ac->zonelist,
+ ac->high_zoneidx, ac->nodemask);
+ ac->classzone_idx = zonelist_zone_idx(ac->preferred_zoneref);
page = get_page_from_freelist(gfp_mask, order,
ALLOC_NO_WATERMARKS, ac);
if (page)
next prev parent reply other threads:[~2016-05-30 15:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 13:13 BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm, page_alloc: avoid looking up the first zone in a zonelist twice) Geert Uytterhoeven
2016-05-30 15:56 ` Mel Gorman [this message]
2016-05-30 17:37 ` Geert Uytterhoeven
2016-05-30 18:56 ` Mel Gorman
2016-05-31 9:28 ` Geert Uytterhoeven
2016-05-31 10:13 ` Mel Gorman
2016-05-31 21:44 ` Vlastimil Babka
2016-06-01 9:19 ` Mel Gorman
2016-06-01 10:01 ` BUG: scheduling while atomic: cron/668/0x10c9a0c0 Vlastimil Babka
2016-06-02 10:39 ` Mel Gorman
2016-06-02 12:04 ` Vlastimil Babka
2016-06-02 12:19 ` Mel Gorman
2016-06-02 18:43 ` Andrew Morton
2016-06-03 3:52 ` Stephen Rothwell
2016-06-03 7:57 ` Geert Uytterhoeven
2016-06-03 8:41 ` Mel Gorman
2016-06-03 9:00 ` Geert Uytterhoeven
2016-06-03 16:35 ` Andrew Morton
2016-06-03 16:46 ` Mel Gorman
2016-06-03 16:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160530155644.GP2527@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).