From: Mel Gorman <mgorman@techsingularity.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
linux-m68k <linux-m68k@vger.kernel.org>
Subject: Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm, page_alloc: avoid looking up the first zone in a zonelist twice)
Date: Tue, 31 May 2016 11:13:56 +0100 [thread overview]
Message-ID: <20160531101356.GS2527@techsingularity.net> (raw)
In-Reply-To: <CAMuHMdXCN5LeNCNJ9=B5sGAtdd81JeRNrUMSCOjSL_Bx1-tDvA@mail.gmail.com>
On Tue, May 31, 2016 at 11:28:05AM +0200, Geert Uytterhoeven wrote:
> Hi Mel,
>
> On Mon, May 30, 2016 at 8:56 PM, Mel Gorman <mgorman@techsingularity.net> wrote:
> > Thanks. Please try the following instead
> >
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index bb320cde4d6d..557549c81083 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -3024,6 +3024,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
> > apply_fair = false;
> > fair_skipped = false;
> > reset_alloc_batches(ac->preferred_zoneref->zone);
> > + z = ac->preferred_zoneref;
> > goto zonelist_scan;
> > }
>
> Thanks a lot, that seems to fix the issue!.
>
> Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> JFTR, without the fix, sometimes I get a different, but equally obscure, crash
> than the one I posted before:
>
I'm afraid I don't recognise it. Given the nature of the previous bug
though, I have a vague suspicion that someone is not handling a page
allocation failure properly and goes boom later.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2016-05-31 10:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 13:13 BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm, page_alloc: avoid looking up the first zone in a zonelist twice) Geert Uytterhoeven
2016-05-30 15:56 ` Mel Gorman
2016-05-30 17:37 ` Geert Uytterhoeven
2016-05-30 18:56 ` Mel Gorman
2016-05-31 9:28 ` Geert Uytterhoeven
2016-05-31 10:13 ` Mel Gorman [this message]
2016-05-31 21:44 ` Vlastimil Babka
2016-06-01 9:19 ` Mel Gorman
2016-06-01 10:01 ` BUG: scheduling while atomic: cron/668/0x10c9a0c0 Vlastimil Babka
2016-06-02 10:39 ` Mel Gorman
2016-06-02 12:04 ` Vlastimil Babka
2016-06-02 12:19 ` Mel Gorman
2016-06-02 18:43 ` Andrew Morton
2016-06-03 3:52 ` Stephen Rothwell
2016-06-03 7:57 ` Geert Uytterhoeven
2016-06-03 8:41 ` Mel Gorman
2016-06-03 9:00 ` Geert Uytterhoeven
2016-06-03 16:35 ` Andrew Morton
2016-06-03 16:46 ` Mel Gorman
2016-06-03 16:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531101356.GS2527@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).