* [PATCH] net: fjes: fjes_main: Remove create_workqueue
@ 2016-06-02 9:30 Bhaktipriya Shridhar
2016-06-02 14:57 ` Tejun Heo
2016-06-02 23:55 ` Izumi, Taku
0 siblings, 2 replies; 5+ messages in thread
From: Bhaktipriya Shridhar @ 2016-06-02 9:30 UTC (permalink / raw)
To: David S. Miller, Taku Izumi, Florian Westphal, Bhaktipriya Shridhar
Cc: Tejun Heo, netdev, linux-kernel
alloc_workqueue replaces deprecated create_workqueue().
The workqueue adapter->txrx_wq has workitem
&adapter->raise_intr_rxdata_task per adapter. Extended Socket Network
Device is shared memory based, so someone's transmission denotes other's
reception. raise_intr_rxdata_task raises interruption of receivers from
the sender in order to notify receivers.
The workqueue adapter->control_wq has workitem
&adapter->interrupt_watch_task per adapter. interrupt_watch_task is used
to prevent delay of interrupts.
Dedicated workqueues have been used in both cases since the workitems
on the workqueues are involved in normal device operation and require
forward progress under memory pressure.
max_active has been set to 0 since there is no need for throttling
the number of active work items.
Since network devices may be used for memory reclaim,
WQ_MEM_RECLAIM has been set to guarantee forward progress.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/net/fjes/fjes_main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index 86c331b..9006877 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -1187,8 +1187,9 @@ static int fjes_probe(struct platform_device *plat_dev)
adapter->force_reset = false;
adapter->open_guard = false;
- adapter->txrx_wq = create_workqueue(DRV_NAME "/txrx");
- adapter->control_wq = create_workqueue(DRV_NAME "/control");
+ adapter->txrx_wq = alloc_workqueue(DRV_NAME "/txrx", WQ_MEM_RECLAIM, 0);
+ adapter->control_wq = alloc_workqueue(DRV_NAME "/control",
+ WQ_MEM_RECLAIM, 0);
INIT_WORK(&adapter->tx_stall_task, fjes_tx_stall_task);
INIT_WORK(&adapter->raise_intr_rxdata_task,
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net: fjes: fjes_main: Remove create_workqueue
2016-06-02 9:30 [PATCH] net: fjes: fjes_main: Remove create_workqueue Bhaktipriya Shridhar
@ 2016-06-02 14:57 ` Tejun Heo
2016-06-02 23:55 ` Izumi, Taku
1 sibling, 0 replies; 5+ messages in thread
From: Tejun Heo @ 2016-06-02 14:57 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: David S. Miller, Taku Izumi, Florian Westphal, netdev, linux-kernel
On Thu, Jun 02, 2016 at 03:00:57PM +0530, Bhaktipriya Shridhar wrote:
> alloc_workqueue replaces deprecated create_workqueue().
>
> The workqueue adapter->txrx_wq has workitem
> &adapter->raise_intr_rxdata_task per adapter. Extended Socket Network
> Device is shared memory based, so someone's transmission denotes other's
> reception. raise_intr_rxdata_task raises interruption of receivers from
> the sender in order to notify receivers.
>
> The workqueue adapter->control_wq has workitem
> &adapter->interrupt_watch_task per adapter. interrupt_watch_task is used
> to prevent delay of interrupts.
>
> Dedicated workqueues have been used in both cases since the workitems
> on the workqueues are involved in normal device operation and require
> forward progress under memory pressure.
>
> max_active has been set to 0 since there is no need for throttling
> the number of active work items.
>
> Since network devices may be used for memory reclaim,
> WQ_MEM_RECLAIM has been set to guarantee forward progress.
Patch looks good but ditto with the description. I wish it were
clearer.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] net: fjes: fjes_main: Remove create_workqueue
2016-06-02 9:30 [PATCH] net: fjes: fjes_main: Remove create_workqueue Bhaktipriya Shridhar
2016-06-02 14:57 ` Tejun Heo
@ 2016-06-02 23:55 ` Izumi, Taku
2016-06-04 14:01 ` Bhaktipriya Shridhar
1 sibling, 1 reply; 5+ messages in thread
From: Izumi, Taku @ 2016-06-02 23:55 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: Tejun Heo, netdev, linux-kernel, David S. Miller, Florian Westphal
Dear Bhaktipriya,
Thanks. Looks good to me.
Sincerely,
Taku Izumi
> -----Original Message-----
> From: Bhaktipriya Shridhar [mailto:bhaktipriya96@gmail.com]
> Sent: Thursday, June 02, 2016 6:31 PM
> To: David S. Miller; Izumi, Taku/泉 拓; Florian Westphal; Bhaktipriya Shridhar
> Cc: Tejun Heo; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] net: fjes: fjes_main: Remove create_workqueue
>
> alloc_workqueue replaces deprecated create_workqueue().
>
> The workqueue adapter->txrx_wq has workitem
> &adapter->raise_intr_rxdata_task per adapter. Extended Socket Network
> Device is shared memory based, so someone's transmission denotes other's
> reception. raise_intr_rxdata_task raises interruption of receivers from
> the sender in order to notify receivers.
>
> The workqueue adapter->control_wq has workitem
> &adapter->interrupt_watch_task per adapter. interrupt_watch_task is used
> to prevent delay of interrupts.
>
> Dedicated workqueues have been used in both cases since the workitems
> on the workqueues are involved in normal device operation and require
> forward progress under memory pressure.
>
> max_active has been set to 0 since there is no need for throttling
> the number of active work items.
>
> Since network devices may be used for memory reclaim,
> WQ_MEM_RECLAIM has been set to guarantee forward progress.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> drivers/net/fjes/fjes_main.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
> index 86c331b..9006877 100644
> --- a/drivers/net/fjes/fjes_main.c
> +++ b/drivers/net/fjes/fjes_main.c
> @@ -1187,8 +1187,9 @@ static int fjes_probe(struct platform_device *plat_dev)
> adapter->force_reset = false;
> adapter->open_guard = false;
>
> - adapter->txrx_wq = create_workqueue(DRV_NAME "/txrx");
> - adapter->control_wq = create_workqueue(DRV_NAME "/control");
> + adapter->txrx_wq = alloc_workqueue(DRV_NAME "/txrx", WQ_MEM_RECLAIM, 0);
> + adapter->control_wq = alloc_workqueue(DRV_NAME "/control",
> + WQ_MEM_RECLAIM, 0);
>
> INIT_WORK(&adapter->tx_stall_task, fjes_tx_stall_task);
> INIT_WORK(&adapter->raise_intr_rxdata_task,
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: fjes: fjes_main: Remove create_workqueue
2016-06-02 23:55 ` Izumi, Taku
@ 2016-06-04 14:01 ` Bhaktipriya Shridhar
2016-06-04 19:37 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Bhaktipriya Shridhar @ 2016-06-04 14:01 UTC (permalink / raw)
To: Izumi, Taku
Cc: Tejun Heo, netdev, linux-kernel, David S. Miller, Florian Westphal
Thank you for your feedback.
Will send another patch with changed description.
Bhaktipriya.
On Fri, Jun 3, 2016 at 5:25 AM, Izumi, Taku <izumi.taku@jp.fujitsu.com> wrote:
> Dear Bhaktipriya,
>
> Thanks. Looks good to me.
>
> Sincerely,
> Taku Izumi
>
>> -----Original Message-----
>> From: Bhaktipriya Shridhar [mailto:bhaktipriya96@gmail.com]
>> Sent: Thursday, June 02, 2016 6:31 PM
>> To: David S. Miller; Izumi, Taku/泉 拓; Florian Westphal; Bhaktipriya Shridhar
>> Cc: Tejun Heo; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: [PATCH] net: fjes: fjes_main: Remove create_workqueue
>>
>> alloc_workqueue replaces deprecated create_workqueue().
>>
>> The workqueue adapter->txrx_wq has workitem
>> &adapter->raise_intr_rxdata_task per adapter. Extended Socket Network
>> Device is shared memory based, so someone's transmission denotes other's
>> reception. raise_intr_rxdata_task raises interruption of receivers from
>> the sender in order to notify receivers.
>>
>> The workqueue adapter->control_wq has workitem
>> &adapter->interrupt_watch_task per adapter. interrupt_watch_task is used
>> to prevent delay of interrupts.
>>
>> Dedicated workqueues have been used in both cases since the workitems
>> on the workqueues are involved in normal device operation and require
>> forward progress under memory pressure.
>>
>> max_active has been set to 0 since there is no need for throttling
>> the number of active work items.
>>
>> Since network devices may be used for memory reclaim,
>> WQ_MEM_RECLAIM has been set to guarantee forward progress.
>>
>> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
>> ---
>> drivers/net/fjes/fjes_main.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
>> index 86c331b..9006877 100644
>> --- a/drivers/net/fjes/fjes_main.c
>> +++ b/drivers/net/fjes/fjes_main.c
>> @@ -1187,8 +1187,9 @@ static int fjes_probe(struct platform_device *plat_dev)
>> adapter->force_reset = false;
>> adapter->open_guard = false;
>>
>> - adapter->txrx_wq = create_workqueue(DRV_NAME "/txrx");
>> - adapter->control_wq = create_workqueue(DRV_NAME "/control");
>> + adapter->txrx_wq = alloc_workqueue(DRV_NAME "/txrx", WQ_MEM_RECLAIM, 0);
>> + adapter->control_wq = alloc_workqueue(DRV_NAME "/control",
>> + WQ_MEM_RECLAIM, 0);
>>
>> INIT_WORK(&adapter->tx_stall_task, fjes_tx_stall_task);
>> INIT_WORK(&adapter->raise_intr_rxdata_task,
>> --
>> 2.1.4
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: fjes: fjes_main: Remove create_workqueue
2016-06-04 14:01 ` Bhaktipriya Shridhar
@ 2016-06-04 19:37 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2016-06-04 19:37 UTC (permalink / raw)
To: bhaktipriya96; +Cc: izumi.taku, tj, netdev, linux-kernel, fw
From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date: Sat, 4 Jun 2016 19:31:35 +0530
> Thank you for your feedback.
> Will send another patch with changed description.
I already applied your patch to the net-next tree, so that wouldn't
be appropriate.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-04 19:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-02 9:30 [PATCH] net: fjes: fjes_main: Remove create_workqueue Bhaktipriya Shridhar
2016-06-02 14:57 ` Tejun Heo
2016-06-02 23:55 ` Izumi, Taku
2016-06-04 14:01 ` Bhaktipriya Shridhar
2016-06-04 19:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).