From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [BUGFIX][PATCH v6 3/9] perf config: Handle the error when config set is NULL at collect_config()
Date: Mon, 6 Jun 2016 17:25:09 -0300 [thread overview]
Message-ID: <20160606202509.GC15108@kernel.org> (raw)
In-Reply-To: <1465210380-26749-4-git-send-email-treeze.taeung@gmail.com>
Em Mon, Jun 06, 2016 at 07:52:54PM +0900, Taeung Song escreveu:
> collect_config() collect all config key-value pairs
> from config files and put each config info in config set.
> But if config set (i.e. 'set' variable at collect_config())
> is NULL, this is wrong so handle it.
Looks ok, applied.
- Arnaldo
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
> tools/perf/util/config.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
> index d013f90..062eeb8 100644
> --- a/tools/perf/util/config.c
> +++ b/tools/perf/util/config.c
> @@ -607,8 +607,12 @@ static int collect_config(const char *var, const char *value,
> struct perf_config_section *section = NULL;
> struct perf_config_item *item = NULL;
> struct perf_config_set *set = perf_config_set;
> - struct list_head *sections = &set->sections;
> + struct list_head *sections;
>
> + if (set == NULL)
> + return -1;
> +
> + sections = &set->sections;
> key = ptr = strdup(var);
> if (!key) {
> pr_debug("%s: strdup failed\n", __func__);
> --
> 2.5.0
next prev parent reply other threads:[~2016-06-06 20:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 10:52 [RFC][PATCH v6 0/9] perf config: Reimplement perf_config() using perf_config_set__inter() Taeung Song
2016-06-06 10:52 ` [BUGFIX][PATCH v6 1/9] perf config: Fix the problem of abnormal termination at perf_parse_file() Taeung Song
2016-06-06 20:21 ` Arnaldo Carvalho de Melo
2016-06-08 8:40 ` [tip:perf/core] perf config: Fix " tip-bot for Taeung Song
2016-06-06 10:52 ` [BUGFIX][PATCH v6 2/9] perf config: If collect_config() is failed, finally free a config set after it is done Taeung Song
2016-06-06 20:23 ` Arnaldo Carvalho de Melo
2016-06-06 21:37 ` Taeung Song
2016-06-07 7:44 ` Taeung Song
2016-06-06 10:52 ` [BUGFIX][PATCH v6 3/9] perf config: Handle the error when config set is NULL at collect_config() Taeung Song
2016-06-06 20:25 ` Arnaldo Carvalho de Melo [this message]
2016-06-08 8:41 ` [tip:perf/core] " tip-bot for Taeung Song
2016-06-06 10:52 ` [PATCH v6 4/9] perf config: Use new perf_config_set__init() to initialize config set Taeung Song
2016-06-06 10:52 ` [PATCH v6 5/9] perf config: Add global variable 'config_set' Taeung Song
2016-06-06 10:52 ` [PATCH v6 6/9] perf config: Use zfree() instead of free() at perf_config_set__delete() Taeung Song
2016-06-06 10:52 ` [PATCH v6 7/9] perf config: Reimplement perf_config() using perf_config_set__iter() Taeung Song
2016-06-06 10:52 ` [PATCH v6 8/9] perf config: Reset the config set at only 'config' sub-command Taeung Song
2016-06-06 10:53 ` [PATCH v6 9/9] perf config: Reimplement show_config() using perf_config() Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606202509.GC15108@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=treeze.taeung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).