From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [BUGFIX][PATCH v6 2/9] perf config: If collect_config() is failed, finally free a config set after it is done
Date: Tue, 7 Jun 2016 16:44:50 +0900 [thread overview]
Message-ID: <57567B72.7090103@gmail.com> (raw)
In-Reply-To: <5755ED20.7080200@gmail.com>
On 06/07/2016 06:37 AM, Taeung Song wrote:
>
>
> On 06/07/2016 05:23 AM, Arnaldo Carvalho de Melo wrote:
>> Em Mon, Jun 06, 2016 at 07:52:53PM +0900, Taeung Song escreveu:
>>> Because of die() at perf_parse_file() a config set was freed
>>> in collect_config(), if failed.
>>> But it is natural to free a config set after collect_config() is done
>>> when some problems happened.
>>>
>>> So, in case of failure, lastly free a config set at
>>> perf_config_set__new()
>>> instead of freeing the config set in collect_config().
>>>
>>> Cc: Namhyung Kim <namhyung@kernel.org>
>>> Cc: Jiri Olsa <jolsa@redhat.com>
>>> Cc: Masami Hiramatsu <mhiramat@kernel.org>
>>> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
>>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
>>> ---
>>> tools/perf/util/config.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
>>> index b500737..d013f90 100644
>>> --- a/tools/perf/util/config.c
>>> +++ b/tools/perf/util/config.c
>>> @@ -639,7 +639,6 @@ static int collect_config(const char *var, const
>>> char *value,
>>>
>>> out_free:
>>> free(key);
>>> - perf_config_set__delete(set);
>>> return -1;
>>> }
>>>
>>> @@ -649,7 +648,8 @@ struct perf_config_set *perf_config_set__new(void)
>>>
>>> if (set) {
>>> INIT_LIST_HEAD(&set->sections);
>>> - perf_config(collect_config, set);
>>> + if (perf_config(collect_config, set) < 0)
>>> + perf_config_set__delete(set);
>>> }
>>>
>>> return set;
>>
>> You can't do that, there is something missing, without looking at the
>> code I think you need:
>>
>> if (set) {
>> INIT_LIST_HEAD(&set->sections);
>> - perf_config(collect_config, set);
>> + if (perf_config(collect_config, set) < 0) {
>> + perf_config_set__delete(set);
>> + set = NULL;
>> + }
>> }
>>
>> return set;
>>
>> No?
>>
>
> Granted
> Sorry for missing above..
>
> I modified using 'return NULL;' instead of 'set = NULL;' as below
>
> diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
> index c73f1c4..cb749d3 100644
> --- a/tools/perf/util/config.c
> +++ b/tools/perf/util/config.c
> @@ -643,7 +643,6 @@ static int collect_config(const char *var, const
> char *value,
>
> out_free:
> free(key);
> - perf_config_set__delete(set);
> return -1;
> }
>
> @@ -653,7 +652,10 @@ struct perf_config_set *perf_config_set__new(void)
>
> if (set) {
> INIT_LIST_HEAD(&set->sections);
> - perf_config(collect_config, set);
> + if (perf_config(collect_config, set) < 0) {
> + perf_config_set__delete(set);
> + return NULL;
> + }
> }
>
> return set;
>
> Because in near future, perf_config_set__delete() will use zfree().
>
> will send changed this patch soon !
> Thank you for your review :)
>
Hum.. my answer was stupid.
There isn't difference between 'return NULL;' and 'set = NULL;'
as a result at perf_config_set__new().
And zfree() at perf_config_set__delete() aren't related to this situation..
Anyway.. I'll send v7 with changed this patch as you said!!
Thanks,
Taeung
next prev parent reply other threads:[~2016-06-07 7:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 10:52 [RFC][PATCH v6 0/9] perf config: Reimplement perf_config() using perf_config_set__inter() Taeung Song
2016-06-06 10:52 ` [BUGFIX][PATCH v6 1/9] perf config: Fix the problem of abnormal termination at perf_parse_file() Taeung Song
2016-06-06 20:21 ` Arnaldo Carvalho de Melo
2016-06-08 8:40 ` [tip:perf/core] perf config: Fix " tip-bot for Taeung Song
2016-06-06 10:52 ` [BUGFIX][PATCH v6 2/9] perf config: If collect_config() is failed, finally free a config set after it is done Taeung Song
2016-06-06 20:23 ` Arnaldo Carvalho de Melo
2016-06-06 21:37 ` Taeung Song
2016-06-07 7:44 ` Taeung Song [this message]
2016-06-06 10:52 ` [BUGFIX][PATCH v6 3/9] perf config: Handle the error when config set is NULL at collect_config() Taeung Song
2016-06-06 20:25 ` Arnaldo Carvalho de Melo
2016-06-08 8:41 ` [tip:perf/core] " tip-bot for Taeung Song
2016-06-06 10:52 ` [PATCH v6 4/9] perf config: Use new perf_config_set__init() to initialize config set Taeung Song
2016-06-06 10:52 ` [PATCH v6 5/9] perf config: Add global variable 'config_set' Taeung Song
2016-06-06 10:52 ` [PATCH v6 6/9] perf config: Use zfree() instead of free() at perf_config_set__delete() Taeung Song
2016-06-06 10:52 ` [PATCH v6 7/9] perf config: Reimplement perf_config() using perf_config_set__iter() Taeung Song
2016-06-06 10:52 ` [PATCH v6 8/9] perf config: Reset the config set at only 'config' sub-command Taeung Song
2016-06-06 10:53 ` [PATCH v6 9/9] perf config: Reimplement show_config() using perf_config() Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57567B72.7090103@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).