From: Herbert Xu <herbert@gondor.apana.org.au>
To: Megha Dey <megha.dey@intel.com>
Cc: tim.c.chen@linux.intel.com, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
fenghua.yu@intel.com, Megha Dey <megha.dey@linux.intel.com>
Subject: Re: [PATCH V2 2/2] crypto : async implementation for sha1-mb
Date: Tue, 7 Jun 2016 18:35:15 +0800 [thread overview]
Message-ID: <20160607103515.GB325@gondor.apana.org.au> (raw)
In-Reply-To: <1464922430-26976-3-git-send-email-megha.dey@intel.com>
On Thu, Jun 02, 2016 at 07:53:50PM -0700, Megha Dey wrote:
>
> + struct ahash_alg *shash = crypto_ahash_alg(tfm);
>
> /* alignment is to be done by multi-buffer crypto algorithm if needed */
>
> - return shash->finup(desc, NULL, 0, req->result);
> + return shash->finup(desc);
You're still poking in the guts of the API. Now that it's a real
ahash you don't need to do that.
Just do crypto_ahash_finup. That way you don't need to export
crypto_ahsh_alg either.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-06-07 10:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 2:53 [PATCH V2 0/2] Implementation of an async interface for sha1-mb Megha Dey
2016-06-03 2:53 ` [PATCH V2 1/2] crypto: sha1-mb - stylistic cleanup Megha Dey
2016-06-07 10:44 ` Herbert Xu
2016-06-03 2:53 ` [PATCH V2 2/2] crypto : async implementation for sha1-mb Megha Dey
2016-06-07 10:35 ` Herbert Xu [this message]
2016-06-07 18:10 ` Dey, Megha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607103515.GB325@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=fenghua.yu@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=megha.dey@intel.com \
--cc=megha.dey@linux.intel.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).