From: Mark Brown <broonie@kernel.org>
To: Xing Zheng <zhengxing@rock-chips.com>
Cc: Rob Herring <robh@kernel.org>,
linux-rockchip@lists.infradead.org, dianders@chromium.org,
heiko@sntech.de, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219
Date: Tue, 7 Jun 2016 13:06:47 +0100 [thread overview]
Message-ID: <20160607120647.GV7510@sirena.org.uk> (raw)
In-Reply-To: <5756B22F.9000105@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
On Tue, Jun 07, 2016 at 07:38:23PM +0800, Xing Zheng wrote:
> On 2016年06月07日 18:47, Mark Brown wrote:
> > No, that'd be one card with all three CODECs on the same board which I'm
> > guessing isn't the intention?
> Yes, because on our board, the audio connection by hardware really is such:
> |-- max98357a
> i2s0 <==> |-- rt5514
> | -- da7219
> We do need to support max98357a / rt5514 / da7219 via i2s0 on the same board
> for RK3399.
> I remember that it will be failed if we register card with i2s0 more times.
> Therefore, I chose this mothod that create 3 dai-links on one machine
> driver.
OK, then the original name probably makes some sense though really
that's such an unusual design that just naming it after the specific
board might be better, it's not likely to see any reuse I'd guess.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-07 12:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 13:02 [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219 Xing Zheng
2016-05-30 7:32 ` Xing Zheng
2016-05-30 16:03 ` Mark Brown
2016-06-01 14:45 ` Rob Herring
2016-06-03 14:16 ` Xing Zheng
2016-06-06 23:50 ` Mark Brown
2016-06-07 2:49 ` Xing Zheng
2016-06-07 10:47 ` Mark Brown
2016-06-07 11:38 ` Xing Zheng
2016-06-07 12:06 ` Mark Brown [this message]
2016-06-07 12:47 ` Xing Zheng
2016-06-07 13:32 ` Mark Brown
2016-06-07 13:48 ` Xing Zheng
2016-06-07 14:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607120647.GV7510@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).