* [PATCH] dmaengine: xilinx_vdma: Use dma_pool_zalloc
@ 2016-06-07 19:18 Amitoj Kaur Chawla
2016-06-08 3:35 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Amitoj Kaur Chawla @ 2016-06-07 19:18 UTC (permalink / raw)
To: vinod.koul, dan.j.williams, michal.simek, soren.brinkmann,
linux-arm-kernel, dmaengine, linux-kernel
Cc: julia.lawall
Dma_pool_zalloc combines dma_pool_alloc and memset 0.
The Coccinelle semantic patch used to make this change is as follows:
@@
type T;
T *d;
expression e;
statement S;
@@
d =
- dma_pool_alloc
+ dma_pool_zalloc
(...);
if (!d) S
- memset(d, 0, sizeof(T));
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/dma/xilinx/xilinx_vdma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/xilinx/xilinx_vdma.c b/drivers/dma/xilinx/xilinx_vdma.c
index ef67f27..d35317f 100644
--- a/drivers/dma/xilinx/xilinx_vdma.c
+++ b/drivers/dma/xilinx/xilinx_vdma.c
@@ -315,11 +315,10 @@ xilinx_vdma_alloc_tx_segment(struct xilinx_vdma_chan *chan)
struct xilinx_vdma_tx_segment *segment;
dma_addr_t phys;
- segment = dma_pool_alloc(chan->desc_pool, GFP_ATOMIC, &phys);
+ segment = dma_pool_zalloc(chan->desc_pool, GFP_ATOMIC, &phys);
if (!segment)
return NULL;
- memset(segment, 0, sizeof(*segment));
segment->phys = phys;
return segment;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: xilinx_vdma: Use dma_pool_zalloc
2016-06-07 19:18 [PATCH] dmaengine: xilinx_vdma: Use dma_pool_zalloc Amitoj Kaur Chawla
@ 2016-06-08 3:35 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2016-06-08 3:35 UTC (permalink / raw)
To: Amitoj Kaur Chawla
Cc: dan.j.williams, michal.simek, soren.brinkmann, linux-arm-kernel,
dmaengine, linux-kernel, julia.lawall
On Wed, Jun 08, 2016 at 12:48:38AM +0530, Amitoj Kaur Chawla wrote:
> Dma_pool_zalloc combines dma_pool_alloc and memset 0.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> type T;
> T *d;
> expression e;
> statement S;
> @@
>
> d =
> - dma_pool_alloc
> + dma_pool_zalloc
> (...);
> if (!d) S
> - memset(d, 0, sizeof(T));
Thanks for your patch, but I have already applied a similar patch fixing
this.
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-08 3:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-07 19:18 [PATCH] dmaengine: xilinx_vdma: Use dma_pool_zalloc Amitoj Kaur Chawla
2016-06-08 3:35 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).