linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m32r: add __ucmpdi2 to fix build failure
Date: Thu, 9 Jun 2016 15:16:03 -0700	[thread overview]
Message-ID: <20160609151603.79da214c8133130e92ff689a@linux-foundation.org> (raw)
In-Reply-To: <1465509213-4280-1-git-send-email-sudipm.mukherjee@gmail.com>

On Thu,  9 Jun 2016 22:53:33 +0100 Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:

> We are having build failure with m32r and the error message being:
> ERROR: "__ucmpdi2" [lib/842/842_decompress.ko] undefined!
> ERROR: "__ucmpdi2" [fs/btrfs/btrfs.ko] undefined!
> ERROR: "__ucmpdi2" [drivers/scsi/sd_mod.ko] undefined!
> ERROR: "__ucmpdi2" [drivers/media/i2c/adv7842.ko] undefined!
> ERROR: "__ucmpdi2" [drivers/md/bcache/bcache.ko] undefined!
> ERROR: "__ucmpdi2" [drivers/iio/imu/inv_mpu6050/inv-mpu6050.ko] undefined!
> 
> __ucmpdi2 is introduced to m32r architecture taking example from other
> architectures like h8300, microblaze, mips.
> 
> --- a/arch/m32r/kernel/m32r_ksyms.c
> +++ b/arch/m32r/kernel/m32r_ksyms.c
> @@ -41,6 +41,9 @@ EXPORT_SYMBOL(cpu_data);
>  EXPORT_SYMBOL(smp_flush_tlb_page);
>  #endif
>  
> +extern int __ucmpdi2(unsigned long long a, unsigned long long b);
> +EXPORT_SYMBOL(__ucmpdi2);
> +

This would be neater.  Does it work?


From: Andrew Morton <akpm@linux-foundation.org>
Subject: m32r-add-__ucmpdi2-to-fix-build-failure-fix

avoid extern declaration in .c file

Cc: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

--- a/arch/m32r/kernel/m32r_ksyms.c~m32r-add-__ucmpdi2-to-fix-build-failure-fix
+++ a/arch/m32r/kernel/m32r_ksyms.c
@@ -41,7 +41,6 @@ EXPORT_SYMBOL(cpu_data);
 EXPORT_SYMBOL(smp_flush_tlb_page);
 #endif
 
-extern int __ucmpdi2(unsigned long long a, unsigned long long b);
 EXPORT_SYMBOL(__ucmpdi2);
 
 /* compiler generated symbol */
--- a/arch/m32r/lib/libgcc.h~m32r-add-__ucmpdi2-to-fix-build-failure-fix
+++ a/arch/m32r/lib/libgcc.h
@@ -22,3 +22,4 @@ typedef union {
 
 #endif /* __ASM_LIBGCC_H */
 
+extern int __ucmpdi2(unsigned long long a, unsigned long long b);

  reply	other threads:[~2016-06-09 22:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 21:53 [PATCH] m32r: add __ucmpdi2 to fix build failure Sudip Mukherjee
2016-06-09 22:16 ` Andrew Morton [this message]
2016-06-10  7:08   ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160609151603.79da214c8133130e92ff689a@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).