From: Rob Herring <robh@kernel.org>
To: Andrea Merello <andrea.merello@gmail.com>
Cc: dri-devel@lists.freedesktop.org, airlied@linux.ie,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Francesco Diotalevi <francesco.diotalevi@iit.it>,
Claudio Lorini <claudio.lorini@iit.it>
Subject: Re: [PATCH 2/2] drm: Add DT bindings documentation for OpenCores VGA/LCD controller
Date: Fri, 10 Jun 2016 12:36:21 -0500 [thread overview]
Message-ID: <20160610173621.GA17641@rob-hp-laptop> (raw)
In-Reply-To: <1465479199-9810-1-git-send-email-andrea.merello@gmail.com>
On Thu, Jun 09, 2016 at 03:33:19PM +0200, Andrea Merello wrote:
> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
> Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Francesco Diotalevi <francesco.diotalevi@iit.it>
> Cc: Claudio Lorini <claudio.lorini@iit.it>
> ---
> .../bindings/display/opencores,ocdrm.txt | 27 ++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/opencores,ocdrm.txt
>
> diff --git a/Documentation/devicetree/bindings/display/opencores,ocdrm.txt b/Documentation/devicetree/bindings/display/opencores,ocdrm.txt
> new file mode 100644
> index 0000000..8d36de5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/opencores,ocdrm.txt
> @@ -0,0 +1,27 @@
> +OpenCores VGA/LCD controller
> +
> +Required properties:
> +- compatible: "opencores,ocdrm"
Name this based on what the h/w block is called, not a Linux subsystem.
Is there any sort of versioning for OpenCore IP that you can include in
the name?
> +- reg: Physical base address and length of the controller's registers.
> +- clocks: Must contain an entry for the pixelclock generator.
> + See ../clocks/clock-bindings.txt for details.
> +
> +Required sub-nodes:
> +- port: the connection to a DRM bridge. The connection is modelled
Don't include Linux driver details (DRM) in bindings.
> + using the OF graph bindings specified in
> + Documentation/devicetree/bindings/graph.txt.
> +
> +Example:
> +
> +ocdrm@43c10000 {
> + compatible = "opencores,ocfb-drm";
Doesn't match the above and even worse naming.
> + reg = <0x43c10000 0x10000>;
> + clocks = <&pix_clock>;
> + ports {
> + port@0 {
Single port doesn't need a unit address.
> + rgb_out: endpoint {
> + remote-endpoint = <&bridge_in>;
> + };
> + };
> + };
> +};
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-10 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 13:33 [PATCH 2/2] drm: Add DT bindings documentation for OpenCores VGA/LCD controller Andrea Merello
2016-06-10 17:36 ` Rob Herring [this message]
2016-06-27 11:21 ` Andrea Merello
2016-06-27 15:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610173621.GA17641@rob-hp-laptop \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=andrea.merello@gmail.com \
--cc=claudio.lorini@iit.it \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=francesco.diotalevi@iit.it \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).