linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Andrea Merello <andrea.merello@gmail.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	David Airlie <airlied@linux.ie>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Francesco Diotalevi <francesco.diotalevi@iit.it>,
	Claudio Lorini <claudio.lorini@iit.it>
Subject: Re: [PATCH 2/2] drm: Add DT bindings documentation for OpenCores VGA/LCD controller
Date: Mon, 27 Jun 2016 10:24:53 -0500	[thread overview]
Message-ID: <CAL_JsqL2n1gfPmaByV=UbofR8WWiz9bcYsB5_ix6a9dOn=G8GA@mail.gmail.com> (raw)
In-Reply-To: <CAN8YU5MnscQdeC4nx=_YcTmG8peS=mp3vLnvH13dqBfTovM46Q@mail.gmail.com>

On Mon, Jun 27, 2016 at 6:21 AM, Andrea Merello
<andrea.merello@gmail.com> wrote:
> On Fri, Jun 10, 2016 at 7:36 PM, Rob Herring <robh@kernel.org> wrote:
>> On Thu, Jun 09, 2016 at 03:33:19PM +0200, Andrea Merello wrote:
>>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
>>> Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
>>> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
>>> Cc: Francesco Diotalevi <francesco.diotalevi@iit.it>
>>> Cc: Claudio Lorini <claudio.lorini@iit.it>
>>> ---
>>>  .../bindings/display/opencores,ocdrm.txt           | 27 ++++++++++++++++++++++
>>>  1 file changed, 27 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/display/opencores,ocdrm.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/opencores,ocdrm.txt b/Documentation/devicetree/bindings/display/opencores,ocdrm.txt
>>> new file mode 100644
>>> index 0000000..8d36de5
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/display/opencores,ocdrm.txt
>>> @@ -0,0 +1,27 @@
>>> +OpenCores VGA/LCD controller
>>> +
>>> +Required properties:
>>> +- compatible: "opencores,ocdrm"
>>
>> Name this based on what the h/w block is called, not a Linux subsystem.
>
> Ok.
>
> Something like "opencores,video" ?

The VGA/LCD controller IP block is just called "video"?

> The older framebuffer driver has "opencores,ocfb"; I assumed the
> suffix -fb was because of it is a "framebuffer" _driver_, but maybe it
> is because they consider it a "framebuffer" _device_.

Could be either. The FB and DRM "bindings" have been flawed in
general. The bindings should describe hardware blocks and the
connections between them, not what the kernel subsystem wants.

> Maybe I can keep the same "compatible" string? Is it ok to have two
> drivers (maybe temporarily, until the older one fades out) with the
> same "compatible" ?

In principal, that is exactly how it should work. However, the FB
binding is probably incomplete or flawed. If keeping the compatible
string is enough for it to work, then that is fine.

>> Is there any sort of versioning for OpenCore IP that you can include in
>> the name?
>
> Not sure about this. I'll check.
>
>>> +- reg: Physical base address and length of the controller's registers.
>>> +- clocks: Must contain an entry for the pixelclock generator.
>>> +  See ../clocks/clock-bindings.txt for details.
>>> +
>>> +Required sub-nodes:
>>> +- port: the connection to a DRM bridge.  The connection is modelled
>>
>> Don't include Linux driver details (DRM) in bindings.
>
> You mean telling that the port must be a connection to a DRM bridge,
> leaving out further details?

The binding itself and description should not contain the word DRM.
Just say connection to bridge chip or connector.

Rob

      reply	other threads:[~2016-06-27 15:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 13:33 [PATCH 2/2] drm: Add DT bindings documentation for OpenCores VGA/LCD controller Andrea Merello
2016-06-10 17:36 ` Rob Herring
2016-06-27 11:21   ` Andrea Merello
2016-06-27 15:24     ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_JsqL2n1gfPmaByV=UbofR8WWiz9bcYsB5_ix6a9dOn=G8GA@mail.gmail.com' \
    --to=robh@kernel.org \
    --cc=airlied@linux.ie \
    --cc=andrea.merello@gmail.com \
    --cc=claudio.lorini@iit.it \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=francesco.diotalevi@iit.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefan.kristiansson@saunalahti.fi \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).