* [PATCH v2 1/2] ARM: dts: apq8064: rename db600c to SD_600eval
@ 2016-06-10 18:19 Srinivas Kandagatla
2016-06-10 18:19 ` [PATCH v2 2/2] ARM: dts: sd_600eval: Fix eMMC lockup issue Srinivas Kandagatla
0 siblings, 1 reply; 4+ messages in thread
From: Srinivas Kandagatla @ 2016-06-10 18:19 UTC (permalink / raw)
To: Andy Gross
Cc: Rob Herring, David Brown, devicetree, linux-arm-kernel,
linux-kernel, linux-arm-msm, linux-soc, Srinivas Kandagatla
This board has been renamed recently and announced at
https://eragon.einfochips.com/products/sd-600eval.html
So rename this board files so that it reflects actual product in market.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm/boot/dts/Makefile | 2 +-
...row-db600c-pins.dtsi => qcom-apq8064-arrow-sd-600eval-pins.dtsi} | 0
...m-apq8064-arrow-db600c.dts => qcom-apq8064-arrow-sd-600eval.dts} | 6 +++---
3 files changed, 4 insertions(+), 4 deletions(-)
rename arch/arm/boot/dts/{qcom-apq8064-arrow-db600c-pins.dtsi => qcom-apq8064-arrow-sd-600eval-pins.dtsi} (100%)
rename arch/arm/boot/dts/{qcom-apq8064-arrow-db600c.dts => qcom-apq8064-arrow-sd-600eval.dts} (97%)
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 488a943..66e182c 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -573,7 +573,7 @@ dtb-$(CONFIG_ARCH_PRIMA2) += \
dtb-$(CONFIG_ARCH_OXNAS) += \
wd-mbwe.dtb
dtb-$(CONFIG_ARCH_QCOM) += \
- qcom-apq8064-arrow-db600c.dtb \
+ qcom-apq8064-arrow-sd-600eval.dtb \
qcom-apq8064-cm-qs600.dtb \
qcom-apq8064-ifc6410.dtb \
qcom-apq8064-sony-xperia-yuga.dtb \
diff --git a/arch/arm/boot/dts/qcom-apq8064-arrow-db600c-pins.dtsi b/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval-pins.dtsi
similarity index 100%
rename from arch/arm/boot/dts/qcom-apq8064-arrow-db600c-pins.dtsi
rename to arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval-pins.dtsi
diff --git a/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts b/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
similarity index 97%
rename from arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts
rename to arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
index e01b27e..7df0108 100644
--- a/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts
+++ b/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
@@ -1,10 +1,10 @@
#include "qcom-apq8064-v2.0.dtsi"
-#include "qcom-apq8064-arrow-db600c-pins.dtsi"
+#include "qcom-apq8064-arrow-sd-600eval-pins.dtsi"
#include <dt-bindings/gpio/gpio.h>
/ {
- model = "Arrow Electronics, APQ8064 DB600c";
- compatible = "arrow,db600c", "qcom,apq8064";
+ model = "Arrow Electronics, APQ8064 SD_600eval";
+ compatible = "arrow,sd_600eval", "qcom,apq8064";
aliases {
serial0 = &gsbi7_serial;
--
2.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] ARM: dts: sd_600eval: Fix eMMC lockup issue
2016-06-10 18:19 [PATCH v2 1/2] ARM: dts: apq8064: rename db600c to SD_600eval Srinivas Kandagatla
@ 2016-06-10 18:19 ` Srinivas Kandagatla
2016-06-12 4:47 ` Bjorn Andersson
0 siblings, 1 reply; 4+ messages in thread
From: Srinivas Kandagatla @ 2016-06-10 18:19 UTC (permalink / raw)
To: Andy Gross
Cc: Rob Herring, David Brown, devicetree, linux-arm-kernel,
linux-kernel, linux-arm-msm, linux-soc, Parth Pancholi
From: Parth Pancholi <parth.pancholi@einfochips.com>
This board locks up if we stress test the eMMC, as the regulator s4 is
unable to supply enough current for all the peripherials attached to it.
As this supply is wired up to most of the peripherials including DDR,
it resulted in such lockup.
This patch fixes this issue by setting s4 regulator correctly with
Auto power mode.
Reported-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
[Srinivas Kandagatla: rewrote the change log]
Tested-by: Girish Sharma <girish.sharma@einfochips.com>
Signed-off-by: Parth Pancholi <parth.pancholi@einfochips.com>
---
arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts b/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
index 7df0108..39ae2bc 100644
--- a/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
+++ b/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
@@ -1,6 +1,7 @@
#include "qcom-apq8064-v2.0.dtsi"
#include "qcom-apq8064-arrow-sd-600eval-pins.dtsi"
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/mfd/qcom-rpm.h>
/ {
model = "Arrow Electronics, APQ8064 SD_600eval";
@@ -82,7 +83,8 @@
s4 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
- qcom,switch-mode-frequency = <3200000>;
+ qcom,switch-mode-frequency = <1600000>;
+ qcom,force-mode = <QCOM_RPM_FORCE_MODE_AUTO>;
bias-pull-down;
regulator-always-on;
};
--
2.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: sd_600eval: Fix eMMC lockup issue
2016-06-10 18:19 ` [PATCH v2 2/2] ARM: dts: sd_600eval: Fix eMMC lockup issue Srinivas Kandagatla
@ 2016-06-12 4:47 ` Bjorn Andersson
2016-06-13 16:21 ` Srinivas Kandagatla
0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2016-06-12 4:47 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Andy Gross, Rob Herring, David Brown, devicetree,
linux-arm-kernel, linux-kernel, linux-arm-msm, linux-soc,
Parth Pancholi
On Fri 10 Jun 11:19 PDT 2016, Srinivas Kandagatla wrote:
> From: Parth Pancholi <parth.pancholi@einfochips.com>
>
> This board locks up if we stress test the eMMC, as the regulator s4 is
> unable to supply enough current for all the peripherials attached to it.
> As this supply is wired up to most of the peripherials including DDR,
> it resulted in such lockup.
>
> This patch fixes this issue by setting s4 regulator correctly with
> Auto power mode.
>
> Reported-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> [Srinivas Kandagatla: rewrote the change log]
> Tested-by: Girish Sharma <girish.sharma@einfochips.com>
> Signed-off-by: Parth Pancholi <parth.pancholi@einfochips.com>
If I read the msm-3.4 tree correctly most (perhaps all) 8064 devices
should have this setup.
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts b/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
> index 7df0108..39ae2bc 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
> @@ -1,6 +1,7 @@
> #include "qcom-apq8064-v2.0.dtsi"
> #include "qcom-apq8064-arrow-sd-600eval-pins.dtsi"
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/mfd/qcom-rpm.h>
>
> / {
> model = "Arrow Electronics, APQ8064 SD_600eval";
> @@ -82,7 +83,8 @@
> s4 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> - qcom,switch-mode-frequency = <3200000>;
> + qcom,switch-mode-frequency = <1600000>;
> + qcom,force-mode = <QCOM_RPM_FORCE_MODE_AUTO>;
> bias-pull-down;
> regulator-always-on;
> };
> --
> 2.8.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: sd_600eval: Fix eMMC lockup issue
2016-06-12 4:47 ` Bjorn Andersson
@ 2016-06-13 16:21 ` Srinivas Kandagatla
0 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2016-06-13 16:21 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Rob Herring, David Brown, devicetree,
linux-arm-kernel, linux-kernel, linux-arm-msm, linux-soc,
Parth Pancholi
On 12/06/16 05:47, Bjorn Andersson wrote:
> On Fri 10 Jun 11:19 PDT 2016, Srinivas Kandagatla wrote:
>
>> From: Parth Pancholi <parth.pancholi@einfochips.com>
>>
>> This board locks up if we stress test the eMMC, as the regulator s4 is
>> unable to supply enough current for all the peripherials attached to it.
>> As this supply is wired up to most of the peripherials including DDR,
>> it resulted in such lockup.
>>
>> This patch fixes this issue by setting s4 regulator correctly with
>> Auto power mode.
>>
>> Reported-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> [Srinivas Kandagatla: rewrote the change log]
>> Tested-by: Girish Sharma <girish.sharma@einfochips.com>
>> Signed-off-by: Parth Pancholi <parth.pancholi@einfochips.com>
>
> If I read the msm-3.4 tree correctly most (perhaps all) 8064 devices
> should have this setup.
>
I agree, we should patch other boards as well with the same value.
> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
thanks,
srini
>
> Regards,
> Bjorn
>
>> ---
>> arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts b/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
>> index 7df0108..39ae2bc 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
>> @@ -1,6 +1,7 @@
>> #include "qcom-apq8064-v2.0.dtsi"
>> #include "qcom-apq8064-arrow-sd-600eval-pins.dtsi"
>> #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/mfd/qcom-rpm.h>
>>
>> / {
>> model = "Arrow Electronics, APQ8064 SD_600eval";
>> @@ -82,7 +83,8 @@
>> s4 {
>> regulator-min-microvolt = <1800000>;
>> regulator-max-microvolt = <1800000>;
>> - qcom,switch-mode-frequency = <3200000>;
>> + qcom,switch-mode-frequency = <1600000>;
>> + qcom,force-mode = <QCOM_RPM_FORCE_MODE_AUTO>;
>> bias-pull-down;
>> regulator-always-on;
>> };
>> --
>> 2.8.3
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-13 16:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-10 18:19 [PATCH v2 1/2] ARM: dts: apq8064: rename db600c to SD_600eval Srinivas Kandagatla
2016-06-10 18:19 ` [PATCH v2 2/2] ARM: dts: sd_600eval: Fix eMMC lockup issue Srinivas Kandagatla
2016-06-12 4:47 ` Bjorn Andersson
2016-06-13 16:21 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).