From: Mark Brown <broonie@kernel.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Simran Rai <ssimran@broadcom.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] dma: remove bad_dma_ops to fix build fail
Date: Mon, 13 Jun 2016 10:29:34 +0100 [thread overview]
Message-ID: <20160613092934.GE2282@sirena.org.uk> (raw)
In-Reply-To: <20160613074112.GA2031@sudip-tp>
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
On Mon, Jun 13, 2016 at 08:41:12AM +0100, Sudip Mukherjee wrote:
> On Sun, Jun 12, 2016 at 02:32:24PM -0700, Jerry Snitselaar wrote:
> > config SND_SOC_CYGNUS
> > tristate "SoC platform audio for Broadcom Cygnus chips"
> > depends on ARCH_BCM_CYGNUS || COMPILE_TEST
> > + depends on HAS_DMA
> > help
> > Say Y if you want to add support for ASoC audio on Broadcom
> > Cygnus chips (bcm958300, bcm958305, bcm911360)
> well, I have been doing the exact same thing for all the drivers that was
> failing to build but in my last patch Mark suggested to have stub
> implementation in the arch [1]. So while looking for that I noticed
> bad_dma_ops is not defined by anyone. So what will you suggest?
Right, we've got a couple of obscure architectures with no DMA support
which are leading to a constant stream of patches like this that are
being triggered by compile coverage stuff. In situations like this we
very often provide stubs rather than having to handle this in lots of
different places in the code.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-13 9:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 20:25 [PATCH] dma: remove bad_dma_ops to fix build fail Sudip Mukherjee
2016-06-12 21:32 ` Jerry Snitselaar
2016-06-13 7:41 ` Sudip Mukherjee
2016-06-13 9:29 ` Mark Brown [this message]
2016-06-13 10:51 ` Sudip Mukherjee
2016-06-13 11:59 ` Mark Brown
2016-06-13 12:11 ` Sudip Mukherjee
2016-06-13 7:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613092934.GE2282@sirena.org.uk \
--to=broonie@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ssimran@broadcom.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).