* [PATCH 1/1] mwiflex: avoid possible null pointer dereference
@ 2016-05-17 23:16 Heinrich Schuchardt
2016-06-14 14:21 ` [1/1] " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2016-05-17 23:16 UTC (permalink / raw)
To: Amitkumar Karwar, Nishant Sarmukadam, Kalle Valo
Cc: linux-wireless, netdev, linux-kernel, Heinrich Schuchardt
Do not dereference card before checking against NULL value.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/net/wireless/marvell/mwifiex/pcie.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c
index 0c7937e..ae1f79e 100644
--- a/drivers/net/wireless/marvell/mwifiex/pcie.c
+++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
@@ -2901,10 +2901,11 @@ static void mwifiex_unregister_dev(struct mwifiex_adapter *adapter)
{
struct pcie_service_card *card = adapter->card;
const struct mwifiex_pcie_card_reg *reg;
- struct pci_dev *pdev = card->dev;
+ struct pci_dev *pdev;
int i;
if (card) {
+ pdev = card->dev;
if (card->msix_enable) {
for (i = 0; i < MWIFIEX_NUM_MSIX_VECTORS; i++)
synchronize_irq(card->msix_entries[i].vector);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [1/1] mwiflex: avoid possible null pointer dereference
2016-05-17 23:16 [PATCH 1/1] mwiflex: avoid possible null pointer dereference Heinrich Schuchardt
@ 2016-06-14 14:21 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2016-06-14 14:21 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Amitkumar Karwar, Nishant Sarmukadam, linux-wireless, netdev,
linux-kernel, Heinrich Schuchardt
Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> Do not dereference card before checking against NULL value.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Thanks, 1 patch applied to wireless-drivers-next.git:
141bcf099076 mwiflex: avoid possible null pointer dereference
--
Sent by pwcli
https://patchwork.kernel.org/patch/9115521/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-14 14:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-17 23:16 [PATCH 1/1] mwiflex: avoid possible null pointer dereference Heinrich Schuchardt
2016-06-14 14:21 ` [1/1] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).