From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v2 3/6] i.MX: system.c: Replace magic numbers
Date: Wed, 15 Jun 2016 08:18:15 +0200 [thread overview]
Message-ID: <20160615061815.GZ26768@pengutronix.de> (raw)
In-Reply-To: <1465954193-5894-4-git-send-email-andrew.smirnov@gmail.com>
Hello,
On Tue, Jun 14, 2016 at 06:29:50PM -0700, Andrey Smirnov wrote:
> diff --git a/arch/arm/include/asm/hardware/cache-l2x0.h b/arch/arm/include/asm/hardware/cache-l2x0.h
> index 3a5ec1c..e0ce59c 100644
> --- a/arch/arm/include/asm/hardware/cache-l2x0.h
> +++ b/arch/arm/include/asm/hardware/cache-l2x0.h
> @@ -121,6 +121,7 @@
> #define L310_AUX_CTRL_STORE_LIMITATION BIT(11) /* R2P0+ */
> #define L310_AUX_CTRL_EXCLUSIVE_CACHE BIT(12)
> #define L310_AUX_CTRL_ASSOCIATIVITY_16 BIT(16)
> +
> #define L310_AUX_CTRL_CACHE_REPLACE_RR BIT(25) /* R2P0+ */
> #define L310_AUX_CTRL_NS_LOCKDOWN BIT(26)
> #define L310_AUX_CTRL_NS_INT_CTRL BIT(27)
I'd not include this hunk in this patch.
> diff --git a/arch/arm/mach-imx/system.c b/arch/arm/mach-imx/system.c
> index b153376..f0a9787 100644
> --- a/arch/arm/mach-imx/system.c
> +++ b/arch/arm/mach-imx/system.c
> @@ -109,7 +109,10 @@ void __init imx_init_l2cache(void)
> if (!(readl_relaxed(l2x0_base + L2X0_CTRL) & L2X0_CTRL_EN)) {
> /* Configure the L2 PREFETCH and POWER registers */
> val = readl_relaxed(l2x0_base + L310_PREFETCH_CTRL);
> - val |= 0x70800000;
> + val |= L310_PREFETCH_CTRL_DBL_LINEFILL |
s/ / / ?
> + L310_PREFETCH_CTRL_INSTR_PREFETCH |
> + L310_PREFETCH_CTRL_DATA_PREFETCH |
> + L310_PREFETCH_CTRL_DBL_LINEFILL_INCR;
> writel_relaxed(val, l2x0_base + L310_PREFETCH_CTRL);
> }
>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2016-06-15 6:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 1:29 [PATCH v2 0/6] i.MX L2-cache code cleanups and performance tweaks Andrey Smirnov
2016-06-15 1:29 ` [PATCH v2 1/6] i.MX: system.c: Convert goto to if statement Andrey Smirnov
2016-06-15 1:29 ` [PATCH v2 2/6] i.MX: system.c: Remove redundant errata 752271 code Andrey Smirnov
2016-06-15 1:29 ` [PATCH v2 3/6] i.MX: system.c: Replace magic numbers Andrey Smirnov
2016-06-15 6:18 ` Uwe Kleine-König [this message]
2016-06-16 2:00 ` Shawn Guo
2016-06-15 1:29 ` [PATCH v2 4/6] ARM: cache-l2x0: Do not clear bit 23 in prefetch control register Andrey Smirnov
2016-06-15 1:29 ` [PATCH v2 5/6] i.MX: system.c: Tweak prefetch settings for performance Andrey Smirnov
2016-06-15 1:29 ` [PATCH v2 6/6] i.MX: Do not explicitly call l2x0_of_init() Andrey Smirnov
2016-06-15 10:41 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615061815.GZ26768@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=arnd@arndb.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).