* [PATCH 1/7] Input: synaptics-rmi4: Increment the refcount of the transport dev's of_node
@ 2016-06-03 18:39 Andrew Duggan
2016-06-15 9:24 ` Benjamin Tissoires
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Duggan @ 2016-06-03 18:39 UTC (permalink / raw)
To: linux-input, linux-kernel
Cc: Andrew Duggan, Dmitry Torokhov, Linus Walleij, Jiri Kosina,
Benjamin Tissoires, Vincent Huang, Nick Dyer
Increment the refcount for the transport device's of_node before calling
of_find_node_by_name(). Since of_find_node_by_name() assumes the refcount
was incremented by the caller and calls of_node_put() when it is done.
Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
---
drivers/input/rmi4/rmi_bus.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
index b368b05..55b5336 100644
--- a/drivers/input/rmi4/rmi_bus.c
+++ b/drivers/input/rmi4/rmi_bus.c
@@ -157,11 +157,12 @@ static int rmi_function_match(struct device *dev, struct device_driver *drv)
static void rmi_function_of_probe(struct rmi_function *fn)
{
char of_name[9];
+ struct device_node *node = fn->rmi_dev->xport->dev->of_node;
snprintf(of_name, sizeof(of_name), "rmi4-f%02x",
fn->fd.function_number);
- fn->dev.of_node = of_find_node_by_name(
- fn->rmi_dev->xport->dev->of_node, of_name);
+ of_node_get(node);
+ fn->dev.of_node = of_find_node_by_name(node, of_name);
}
#else
static inline void rmi_function_of_probe(struct rmi_function *fn)
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/7] Input: synaptics-rmi4: Increment the refcount of the transport dev's of_node
2016-06-03 18:39 [PATCH 1/7] Input: synaptics-rmi4: Increment the refcount of the transport dev's of_node Andrew Duggan
@ 2016-06-15 9:24 ` Benjamin Tissoires
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2016-06-15 9:24 UTC (permalink / raw)
To: Andrew Duggan
Cc: linux-input, linux-kernel, Dmitry Torokhov, Linus Walleij,
Jiri Kosina, Vincent Huang, Nick Dyer
On Jun 03 2016 or thereabouts, Andrew Duggan wrote:
> Increment the refcount for the transport device's of_node before calling
> of_find_node_by_name(). Since of_find_node_by_name() assumes the refcount
> was incremented by the caller and calls of_node_put() when it is done.
That is some weird API. I guess it must be used with:
of_node = of_find_node_by_name(of_node, of_name);
Anyway:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
> ---
> drivers/input/rmi4/rmi_bus.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
> index b368b05..55b5336 100644
> --- a/drivers/input/rmi4/rmi_bus.c
> +++ b/drivers/input/rmi4/rmi_bus.c
> @@ -157,11 +157,12 @@ static int rmi_function_match(struct device *dev, struct device_driver *drv)
> static void rmi_function_of_probe(struct rmi_function *fn)
> {
> char of_name[9];
> + struct device_node *node = fn->rmi_dev->xport->dev->of_node;
>
> snprintf(of_name, sizeof(of_name), "rmi4-f%02x",
> fn->fd.function_number);
> - fn->dev.of_node = of_find_node_by_name(
> - fn->rmi_dev->xport->dev->of_node, of_name);
> + of_node_get(node);
> + fn->dev.of_node = of_find_node_by_name(node, of_name);
> }
> #else
> static inline void rmi_function_of_probe(struct rmi_function *fn)
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-15 9:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-03 18:39 [PATCH 1/7] Input: synaptics-rmi4: Increment the refcount of the transport dev's of_node Andrew Duggan
2016-06-15 9:24 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).