* [PATCH 5/7] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data
@ 2016-06-03 18:40 Andrew Duggan
2016-06-15 9:32 ` Benjamin Tissoires
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Duggan @ 2016-06-03 18:40 UTC (permalink / raw)
To: linux-input, linux-kernel
Cc: Andrew Duggan, Dmitry Torokhov, Linus Walleij, Jiri Kosina,
Benjamin Tissoires, Vincent Huang, Nick Dyer
The pointer to struct rmi_function in f12_data is never set and was never
used. The fn pointer is also stored in rmi_2d_sensor which is a member of
f12_data.
Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
---
drivers/input/rmi4/rmi_f12.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
index 041a91d..7d66766 100644
--- a/drivers/input/rmi4/rmi_f12.c
+++ b/drivers/input/rmi4/rmi_f12.c
@@ -27,7 +27,6 @@ enum rmi_f12_object_type {
};
struct f12_data {
- struct rmi_function *fn;
struct rmi_2d_sensor sensor;
struct rmi_2d_sensor_platform_data sensor_pdata;
bool has_dribble;
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 5/7] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data
2016-06-03 18:40 [PATCH 5/7] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data Andrew Duggan
@ 2016-06-15 9:32 ` Benjamin Tissoires
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2016-06-15 9:32 UTC (permalink / raw)
To: Andrew Duggan
Cc: linux-input, linux-kernel, Dmitry Torokhov, Linus Walleij,
Jiri Kosina, Vincent Huang, Nick Dyer
On Jun 03 2016 or thereabouts, Andrew Duggan wrote:
> The pointer to struct rmi_function in f12_data is never set and was never
> used. The fn pointer is also stored in rmi_2d_sensor which is a member of
> f12_data.
>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
> ---
If it compiles, you are OK :)
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> drivers/input/rmi4/rmi_f12.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
> index 041a91d..7d66766 100644
> --- a/drivers/input/rmi4/rmi_f12.c
> +++ b/drivers/input/rmi4/rmi_f12.c
> @@ -27,7 +27,6 @@ enum rmi_f12_object_type {
> };
>
> struct f12_data {
> - struct rmi_function *fn;
> struct rmi_2d_sensor sensor;
> struct rmi_2d_sensor_platform_data sensor_pdata;
> bool has_dribble;
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-15 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-03 18:40 [PATCH 5/7] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data Andrew Duggan
2016-06-15 9:32 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).