* [PATCH v2] iommu/amd: Set AMD iommu callbacks for platform bus driver
@ 2016-05-10 13:21 Wan Zongshun
2016-06-14 3:13 ` Wan ZongShun
2016-06-15 10:00 ` Joerg Roedel
0 siblings, 2 replies; 3+ messages in thread
From: Wan Zongshun @ 2016-05-10 13:21 UTC (permalink / raw)
To: Joerg Roedel, iommu; +Cc: vw, mcuos.com, linux-kernel, Wan Zongshun
From: Wan Zongshun <Vincent.Wan@amd.com>
AMD has more drivers will use ACPI to platform bus driver later,
all those devices need iommu support, for example: eMMC driver.
For latest AMD eMMC controller, it will utilize sdhci-acpi.c driver,
which will rely on platform bus to match device and driver, where we
will set 'dev' of struct platform_device as map_sg parameter passing
to iommu driver for DMA request, so the iommu-ops are needed on the
platform bus.
Signed-off-by: Wan Zongshun <Vincent.Wan@amd.com>
---
changes from v1: Add comment why the iommu-ops are needed on platform bus.
---
drivers/iommu/amd_iommu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index c430c10..547cdd4 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -21,6 +21,7 @@
#include <linux/pci.h>
#include <linux/acpi.h>
#include <linux/amba/bus.h>
+#include <linux/platform_device.h>
#include <linux/pci-ats.h>
#include <linux/bitmap.h>
#include <linux/slab.h>
@@ -2980,6 +2981,9 @@ int __init amd_iommu_init_api(void)
if (err)
return err;
#endif
+ err = bus_set_iommu(&platform_bus_type, &amd_iommu_ops);
+ if (err)
+ return err;
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] iommu/amd: Set AMD iommu callbacks for platform bus driver
2016-05-10 13:21 [PATCH v2] iommu/amd: Set AMD iommu callbacks for platform bus driver Wan Zongshun
@ 2016-06-14 3:13 ` Wan ZongShun
2016-06-15 10:00 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Wan ZongShun @ 2016-06-14 3:13 UTC (permalink / raw)
To: Wan Zongshun; +Cc: Joerg Roedel, iommu, vw, linux-kernel
2016-05-10 21:21 GMT+08:00 Wan Zongshun <vincent.wan@amd.com>:
> From: Wan Zongshun <Vincent.Wan@amd.com>
>
> AMD has more drivers will use ACPI to platform bus driver later,
> all those devices need iommu support, for example: eMMC driver.
>
> For latest AMD eMMC controller, it will utilize sdhci-acpi.c driver,
> which will rely on platform bus to match device and driver, where we
> will set 'dev' of struct platform_device as map_sg parameter passing
> to iommu driver for DMA request, so the iommu-ops are needed on the
> platform bus.
Joerg,
How about this patch? it will impact our new eMMC controller driver bringup.
Thanks.
>
> Signed-off-by: Wan Zongshun <Vincent.Wan@amd.com>
>
> ---
> changes from v1: Add comment why the iommu-ops are needed on platform bus.
> ---
> drivers/iommu/amd_iommu.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index c430c10..547cdd4 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -21,6 +21,7 @@
> #include <linux/pci.h>
> #include <linux/acpi.h>
> #include <linux/amba/bus.h>
> +#include <linux/platform_device.h>
> #include <linux/pci-ats.h>
> #include <linux/bitmap.h>
> #include <linux/slab.h>
> @@ -2980,6 +2981,9 @@ int __init amd_iommu_init_api(void)
> if (err)
> return err;
> #endif
> + err = bus_set_iommu(&platform_bus_type, &amd_iommu_ops);
> + if (err)
> + return err;
> return 0;
> }
>
> --
> 1.9.1
>
--
---
Vincent Wan(Zongshun)
www.mcuos.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] iommu/amd: Set AMD iommu callbacks for platform bus driver
2016-05-10 13:21 [PATCH v2] iommu/amd: Set AMD iommu callbacks for platform bus driver Wan Zongshun
2016-06-14 3:13 ` Wan ZongShun
@ 2016-06-15 10:00 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2016-06-15 10:00 UTC (permalink / raw)
To: Wan Zongshun; +Cc: iommu, vw, mcuos.com, linux-kernel
On Tue, May 10, 2016 at 09:21:01AM -0400, Wan Zongshun wrote:
> From: Wan Zongshun <Vincent.Wan@amd.com>
>
> AMD has more drivers will use ACPI to platform bus driver later,
> all those devices need iommu support, for example: eMMC driver.
>
> For latest AMD eMMC controller, it will utilize sdhci-acpi.c driver,
> which will rely on platform bus to match device and driver, where we
> will set 'dev' of struct platform_device as map_sg parameter passing
> to iommu driver for DMA request, so the iommu-ops are needed on the
> platform bus.
>
> Signed-off-by: Wan Zongshun <Vincent.Wan@amd.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-15 10:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-10 13:21 [PATCH v2] iommu/amd: Set AMD iommu callbacks for platform bus driver Wan Zongshun
2016-06-14 3:13 ` Wan ZongShun
2016-06-15 10:00 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).