From: Dan Carpenter <dan.carpenter@oracle.com>
To: Or Gerlitz <ogerlitz@mellanox.com>
Cc: Leon Romanovsky <leon@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] devlink: clean up a condition
Date: Thu, 16 Jun 2016 09:50:32 +0300 [thread overview]
Message-ID: <20160616065032.GB23129@mwanda> (raw)
Presumably having a _get() function implies that we also have a _set()
function but lets make it match when we're calling.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/core/devlink.c b/net/core/devlink.c
index a4f88cb..b2e592a 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -1461,7 +1461,7 @@ static int devlink_nl_cmd_eswitch_mode_set_doit(struct sk_buff *skb,
mode = nla_get_u16(info->attrs[DEVLINK_ATTR_ESWITCH_MODE]);
- if (ops && ops->eswitch_mode_get)
+ if (ops && ops->eswitch_mode_set)
return ops->eswitch_mode_set(devlink, mode);
return -EOPNOTSUPP;
}
next reply other threads:[~2016-06-16 6:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 6:50 Dan Carpenter [this message]
2016-06-16 14:15 ` [patch] devlink: clean up a condition Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616065032.GB23129@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).