From: Or Gerlitz <ogerlitz@mellanox.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Leon Romanovsky <leon@kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>,
Saeed Mahameed <saeedm@mellanox.com>,
Hadar Har-Zion <hadarh@mellanox.com>
Subject: Re: [patch] devlink: clean up a condition
Date: Thu, 16 Jun 2016 17:15:49 +0300 [thread overview]
Message-ID: <326e2050-176c-291a-a1ec-2d5f13930657@mellanox.com> (raw)
In-Reply-To: <20160616065032.GB23129@mwanda>
On 6/16/2016 9:50 AM, Dan Carpenter wrote:
> Presumably having a _get() function implies that we also have a _set()
> function but lets make it match when we're calling.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index a4f88cb..b2e592a 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -1461,7 +1461,7 @@ static int devlink_nl_cmd_eswitch_mode_set_doit(struct sk_buff *skb,
>
> mode = nla_get_u16(info->attrs[DEVLINK_ATTR_ESWITCH_MODE]);
>
> - if (ops && ops->eswitch_mode_get)
> + if (ops && ops->eswitch_mode_set)
> return ops->eswitch_mode_set(devlink, mode);
> return -EOPNOTSUPP;
> }
good catch Dan, we will incorporate that into the patch set
prev parent reply other threads:[~2016-06-16 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 6:50 [patch] devlink: clean up a condition Dan Carpenter
2016-06-16 14:15 ` Or Gerlitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=326e2050-176c-291a-a1ec-2d5f13930657@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=dan.carpenter@oracle.com \
--cc=hadarh@mellanox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).