* [PATCH] drm: rockchip: select DRM_GEM_CMA_HELPER
@ 2016-06-16 12:27 Arnd Bergmann
2016-06-16 12:37 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-06-16 12:27 UTC (permalink / raw)
To: Mark Yao, David Airlie, Heiko Stuebner
Cc: Arnd Bergmann, Yakir Yang, Chris Zhong, dri-devel,
linux-arm-kernel, linux-rockchip, linux-kernel
The rockchip drm driver started using drm_gem_cma_vm_ops, but that might
not be part of the kernel, causing the link to fail:
drivers/gpu/built-in.o:(.data+0xb234): undefined reference to `drm_gem_cma_vm_ops'
This adds a Kconfig 'select' statement to enable it like the other
user do.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 80f67cd80add ("drm/rockchip: Use cma gem vm ops")
---
drivers/gpu/drm/rockchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
index d30bdc38a760..e48611e83c03 100644
--- a/drivers/gpu/drm/rockchip/Kconfig
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -2,6 +2,7 @@ config DRM_ROCKCHIP
tristate "DRM Support for Rockchip"
depends on DRM && ROCKCHIP_IOMMU
depends on RESET_CONTROLLER
+ select DRM_GEM_CMA_HELPER
select DRM_KMS_HELPER
select DRM_KMS_FB_HELPER
select DRM_PANEL
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: rockchip: select DRM_GEM_CMA_HELPER
2016-06-16 12:27 [PATCH] drm: rockchip: select DRM_GEM_CMA_HELPER Arnd Bergmann
@ 2016-06-16 12:37 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2016-06-16 12:37 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mark Yao, David Airlie, Heiko Stuebner, linux-kernel, dri-devel,
linux-rockchip, Chris Zhong, linux-arm-kernel
On Thu, Jun 16, 2016 at 02:27:57PM +0200, Arnd Bergmann wrote:
> The rockchip drm driver started using drm_gem_cma_vm_ops, but that might
> not be part of the kernel, causing the link to fail:
>
> drivers/gpu/built-in.o:(.data+0xb234): undefined reference to `drm_gem_cma_vm_ops'
>
> This adds a Kconfig 'select' statement to enable it like the other
> user do.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 80f67cd80add ("drm/rockchip: Use cma gem vm ops")
Applied to drm-misc, thanks.
-Daniel
> ---
> drivers/gpu/drm/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index d30bdc38a760..e48611e83c03 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -2,6 +2,7 @@ config DRM_ROCKCHIP
> tristate "DRM Support for Rockchip"
> depends on DRM && ROCKCHIP_IOMMU
> depends on RESET_CONTROLLER
> + select DRM_GEM_CMA_HELPER
> select DRM_KMS_HELPER
> select DRM_KMS_FB_HELPER
> select DRM_PANEL
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-16 12:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-16 12:27 [PATCH] drm: rockchip: select DRM_GEM_CMA_HELPER Arnd Bergmann
2016-06-16 12:37 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).