From: Steven Rostedt <rostedt@goodmis.org>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com,
namhyung@kernel.org, kapileshwar.singh@arm.com,
scottwood@freescale.com, hekuang@huawei.com
Subject: Re: [RFC/PATCH] perf: Add sizeof operator support
Date: Fri, 17 Jun 2016 12:17:36 -0400 [thread overview]
Message-ID: <20160617121736.023f009f@gandalf.local.home> (raw)
In-Reply-To: <1465922312-30064-1-git-send-email-jeremy.linton@arm.com>
On Tue, 14 Jun 2016 11:38:32 -0500
Jeremy Linton <jeremy.linton@arm.com> wrote:
> There are a fair number of tracepoints in the kernel making
> use of the sizeof operator. Allow perf to understand some of
> those cases, and report a more informative error message for
> the ones it cannot understand.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
>
> So this is as much a RFC as a patch because the use of sizeof
> seems to extend to structures, pointers, etc that aren't easy
> to deduce from userspace. I'm not sure what the correct solution
> should be in those cases.
>
> tools/lib/traceevent/event-parse.c | 46 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index a8b6357..5813248 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -31,6 +31,8 @@
> #include <errno.h>
> #include <stdint.h>
> #include <limits.h>
> +#include <linux/kernel.h>
> +#include <linux/types.h>
>
> #include <netinet/ip6.h>
> #include "event-parse.h"
> @@ -2868,6 +2870,46 @@ process_str(struct event_format *event __maybe_unused, struct print_arg *arg,
> }
>
> static enum event_type
> +process_sizeof(struct event_format *event __maybe_unused, struct print_arg *arg,
> + char **tok)
> +{
> + char *token;
> + char *atom;
> +
> + if (process_paren(event, arg, &token) < 0)
> + goto out_free;
> +
> + atom = arg->atom.atom;
> + if (arg->type != PRINT_ATOM) {
> + do_warning_event(event, "didn't understand %s for sizeof\n",
> + token);
> + goto out_free_atom;
> + }
> +
> + if (strcmp(token, "__u64") == 0) {
> + if (asprintf(&arg->atom.atom, "%zd", sizeof(__u64)) < 0)
> + goto out_free_atom;
> + } else if (strcmp(token, "__u32") == 0) {
> + if (asprintf(&arg->atom.atom, "%zd", sizeof(__u32)) < 0)
> + goto out_free_atom;
What events are doing sizeof(__u64) and sizeof(__u32)?
First, that's useless, as sizeof(__u64) will always be 8, and
sizeof(__u32) will always be 4.
What exactly is this fixing?
-- Steve
> + } else {
> + do_warning_event(event, "unknown sizeof %s\n", token);
> + goto out_free_atom;
> + }
> +
> + free(atom);
> + *tok = token;
> + return EVENT_DELIM;
> +
> + out_free_atom:
> + free_token(atom);
> + out_free:
> + free_token(token);
> + *tok = NULL;
> + return EVENT_ERROR;
> +}
> +
> +static enum event_type
> process_bitmask(struct event_format *event __maybe_unused, struct print_arg *arg,
> char **tok)
> {
> @@ -3026,6 +3068,10 @@ process_function(struct event_format *event, struct print_arg *arg,
> free_token(token);
> return process_dynamic_array_len(event, arg, tok);
> }
> + if (strcmp(token, "sizeof") == 0) {
> + free_token(token);
> + return process_sizeof(event, arg, tok);
> + }
>
> func = find_func_handler(event->pevent, token);
> if (func) {
next prev parent reply other threads:[~2016-06-17 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 16:38 [RFC/PATCH] perf: Add sizeof operator support Jeremy Linton
2016-06-17 16:17 ` Steven Rostedt [this message]
2016-06-17 16:32 ` Jeremy Linton
2016-06-17 16:50 ` Steven Rostedt
2016-06-17 18:57 ` Jeremy Linton
2016-06-17 19:08 ` Steven Rostedt
2016-06-20 0:29 ` Namhyung Kim
2017-04-30 22:06 ` Jon Masters
2017-05-02 11:47 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617121736.023f009f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=acme@redhat.com \
--cc=hekuang@huawei.com \
--cc=jeremy.linton@arm.com \
--cc=kapileshwar.singh@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).