* [PATCH] jbd2: make journal y2038 safe
@ 2016-06-17 15:39 Arnd Bergmann
2016-06-19 15:53 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2016-06-17 15:39 UTC (permalink / raw)
To: Theodore Ts'o, Jan Kara
Cc: y2038, Arnd Bergmann, linux-ext4, linux-kernel
The jbd2 journal stores the commit time in 64-bit seconds and 32-bit
nanoseconds, which avoids an overflow in 2038, but it gets the numbers
from current_kernel_time(), which uses 'long' seconds on 32-bit
architectures.
This simply changes the code to call current_kernel_time64() so
we use 64-bit seconds consistently.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/jbd2/commit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c
index 8f7d1339c973..5bb565f9989c 100644
--- a/fs/jbd2/commit.c
+++ b/fs/jbd2/commit.c
@@ -124,7 +124,7 @@ static int journal_submit_commit_record(journal_t *journal,
struct commit_header *tmp;
struct buffer_head *bh;
int ret;
- struct timespec now = current_kernel_time();
+ struct timespec64 now = current_kernel_time64();
*cbh = NULL;
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] jbd2: make journal y2038 safe
2016-06-17 15:39 [PATCH] jbd2: make journal y2038 safe Arnd Bergmann
@ 2016-06-19 15:53 ` Jan Kara
2016-06-30 15:49 ` Theodore Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2016-06-19 15:53 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Theodore Ts'o, Jan Kara, y2038, linux-ext4, linux-kernel
On Fri 17-06-16 17:39:00, Arnd Bergmann wrote:
> The jbd2 journal stores the commit time in 64-bit seconds and 32-bit
> nanoseconds, which avoids an overflow in 2038, but it gets the numbers
> from current_kernel_time(), which uses 'long' seconds on 32-bit
> architectures.
>
> This simply changes the code to call current_kernel_time64() so
> we use 64-bit seconds consistently.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
The patch looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/jbd2/commit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c
> index 8f7d1339c973..5bb565f9989c 100644
> --- a/fs/jbd2/commit.c
> +++ b/fs/jbd2/commit.c
> @@ -124,7 +124,7 @@ static int journal_submit_commit_record(journal_t *journal,
> struct commit_header *tmp;
> struct buffer_head *bh;
> int ret;
> - struct timespec now = current_kernel_time();
> + struct timespec64 now = current_kernel_time64();
>
> *cbh = NULL;
>
> --
> 2.9.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] jbd2: make journal y2038 safe
2016-06-19 15:53 ` Jan Kara
@ 2016-06-30 15:49 ` Theodore Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2016-06-30 15:49 UTC (permalink / raw)
To: Jan Kara; +Cc: Arnd Bergmann, Jan Kara, y2038, linux-ext4, linux-kernel
On Sun, Jun 19, 2016 at 05:53:47PM +0200, Jan Kara wrote:
> On Fri 17-06-16 17:39:00, Arnd Bergmann wrote:
> > The jbd2 journal stores the commit time in 64-bit seconds and 32-bit
> > nanoseconds, which avoids an overflow in 2038, but it gets the numbers
> > from current_kernel_time(), which uses 'long' seconds on 32-bit
> > architectures.
> >
> > This simply changes the code to call current_kernel_time64() so
> > we use 64-bit seconds consistently.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> The patch looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-30 15:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-17 15:39 [PATCH] jbd2: make journal y2038 safe Arnd Bergmann
2016-06-19 15:53 ` Jan Kara
2016-06-30 15:49 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).