* [PATCH] clk: renesas: build clk-rcar-gen2.o for R8A7792
@ 2016-06-20 15:43 Arnd Bergmann
2016-06-20 17:34 ` Sergei Shtylyov
2016-06-20 20:27 ` Geert Uytterhoeven
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-06-20 15:43 UTC (permalink / raw)
To: Simon Horman, Magnus Damm
Cc: Geert Uytterhoeven, Sergei Shtylyov, Arnd Bergmann,
Michael Turquette, Stephen Boyd, Laurent Pinchart, linux-clk,
linux-kernel
The newly added support for R8A7792 causes build failures
because we try to call rcar_gen2_clocks_init but that is not
built into the kernel:
arch/arm/mach-shmobile/built-in.o: In function `rcar_gen2_timer_init':
:(.init.text+0x3b0): undefined reference to `rcar_gen2_clocks_init'
This changes the clk Makefile to match the other platforms, though
I guess it would be better to find another way to do this, e.g.
by not requiring the external function call by relying on
CLK_OF_DECLARE(), or by making the ARCH_RCAR_GEN2 also control
the compilation of the clk driver.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 3ebee0adbfe7 ("ARM: shmobile: r8a7792: basic SoC support")
---
drivers/clk/renesas/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/renesas/Makefile b/drivers/clk/renesas/Makefile
index ead8bb843524..3cdb9aaf8717 100644
--- a/drivers/clk/renesas/Makefile
+++ b/drivers/clk/renesas/Makefile
@@ -6,6 +6,7 @@ obj-$(CONFIG_ARCH_R8A7778) += clk-r8a7778.o
obj-$(CONFIG_ARCH_R8A7779) += clk-r8a7779.o
obj-$(CONFIG_ARCH_R8A7790) += clk-rcar-gen2.o clk-div6.o
obj-$(CONFIG_ARCH_R8A7791) += clk-rcar-gen2.o clk-div6.o
+obj-$(CONFIG_ARCH_R8A7792) += clk-rcar-gen2.o
obj-$(CONFIG_ARCH_R8A7793) += clk-rcar-gen2.o clk-div6.o
obj-$(CONFIG_ARCH_R8A7794) += clk-rcar-gen2.o clk-div6.o
obj-$(CONFIG_ARCH_R8A7795) += r8a7795-cpg-mssr.o
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: renesas: build clk-rcar-gen2.o for R8A7792
2016-06-20 15:43 [PATCH] clk: renesas: build clk-rcar-gen2.o for R8A7792 Arnd Bergmann
@ 2016-06-20 17:34 ` Sergei Shtylyov
2016-06-20 20:27 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2016-06-20 17:34 UTC (permalink / raw)
To: Arnd Bergmann, Simon Horman, Magnus Damm
Cc: Geert Uytterhoeven, Michael Turquette, Stephen Boyd,
Laurent Pinchart, linux-clk, linux-kernel
Hello.
On 06/20/2016 06:43 PM, Arnd Bergmann wrote:
> The newly added support for R8A7792 causes build failures
> because we try to call rcar_gen2_clocks_init but that is not
> built into the kernel:
>
> arch/arm/mach-shmobile/built-in.o: In function `rcar_gen2_timer_init':
> :(.init.text+0x3b0): undefined reference to `rcar_gen2_clocks_init'
>
> This changes the clk Makefile to match the other platforms, though
> I guess it would be better to find another way to do this, e.g.
> by not requiring the external function call by relying on
> CLK_OF_DECLARE(), or by making the ARCH_RCAR_GEN2 also control
> the compilation of the clk driver.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 3ebee0adbfe7 ("ARM: shmobile: r8a7792: basic SoC support")
> ---
> drivers/clk/renesas/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/renesas/Makefile b/drivers/clk/renesas/Makefile
> index ead8bb843524..3cdb9aaf8717 100644
> --- a/drivers/clk/renesas/Makefile
> +++ b/drivers/clk/renesas/Makefile
> @@ -6,6 +6,7 @@ obj-$(CONFIG_ARCH_R8A7778) += clk-r8a7778.o
> obj-$(CONFIG_ARCH_R8A7779) += clk-r8a7779.o
> obj-$(CONFIG_ARCH_R8A7790) += clk-rcar-gen2.o clk-div6.o
> obj-$(CONFIG_ARCH_R8A7791) += clk-rcar-gen2.o clk-div6.o
> +obj-$(CONFIG_ARCH_R8A7792) += clk-rcar-gen2.o
> obj-$(CONFIG_ARCH_R8A7793) += clk-rcar-gen2.o clk-div6.o
> obj-$(CONFIG_ARCH_R8A7794) += clk-rcar-gen2.o clk-div6.o
> obj-$(CONFIG_ARCH_R8A7795) += r8a7795-cpg-mssr.o
It was in the very first patch that I submitted for this SoC:
http://marc.info/?t=146421262300001&r=1
It should be queued up by Geert.
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: renesas: build clk-rcar-gen2.o for R8A7792
2016-06-20 15:43 [PATCH] clk: renesas: build clk-rcar-gen2.o for R8A7792 Arnd Bergmann
2016-06-20 17:34 ` Sergei Shtylyov
@ 2016-06-20 20:27 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2016-06-20 20:27 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Simon Horman, Magnus Damm, Geert Uytterhoeven, Sergei Shtylyov,
Michael Turquette, Stephen Boyd, Laurent Pinchart, linux-clk,
linux-kernel
Hi Arnd,
On Mon, Jun 20, 2016 at 5:43 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added support for R8A7792 causes build failures
> because we try to call rcar_gen2_clocks_init but that is not
> built into the kernel:
>
> arch/arm/mach-shmobile/built-in.o: In function `rcar_gen2_timer_init':
> :(.init.text+0x3b0): undefined reference to `rcar_gen2_clocks_init'
>
> This changes the clk Makefile to match the other platforms, though
> I guess it would be better to find another way to do this, e.g.
> by not requiring the external function call by relying on
> CLK_OF_DECLARE(), or by making the ARCH_RCAR_GEN2 also control
> the compilation of the clk driver.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 3ebee0adbfe7 ("ARM: shmobile: r8a7792: basic SoC support")
> ---
> drivers/clk/renesas/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/renesas/Makefile b/drivers/clk/renesas/Makefile
> index ead8bb843524..3cdb9aaf8717 100644
> --- a/drivers/clk/renesas/Makefile
> +++ b/drivers/clk/renesas/Makefile
> @@ -6,6 +6,7 @@ obj-$(CONFIG_ARCH_R8A7778) += clk-r8a7778.o
> obj-$(CONFIG_ARCH_R8A7779) += clk-r8a7779.o
> obj-$(CONFIG_ARCH_R8A7790) += clk-rcar-gen2.o clk-div6.o
> obj-$(CONFIG_ARCH_R8A7791) += clk-rcar-gen2.o clk-div6.o
> +obj-$(CONFIG_ARCH_R8A7792) += clk-rcar-gen2.o
> obj-$(CONFIG_ARCH_R8A7793) += clk-rcar-gen2.o clk-div6.o
> obj-$(CONFIG_ARCH_R8A7794) += clk-rcar-gen2.o clk-div6.o
> obj-$(CONFIG_ARCH_R8A7795) += r8a7795-cpg-mssr.o
There's already a similar patch in my clk-renesas-for-v4.8 branch.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-20 20:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-20 15:43 [PATCH] clk: renesas: build clk-rcar-gen2.o for R8A7792 Arnd Bergmann
2016-06-20 17:34 ` Sergei Shtylyov
2016-06-20 20:27 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).