From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, wangnan0@huawei.com,
jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com,
namhyung@kernel.org, adrian.hunter@intel.com,
sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com,
tumanova@linux.vnet.ibm.com, kan.liang@intel.com,
penberg@kernel.org, dsahern@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Fixes on remote unwind
Date: Tue, 21 Jun 2016 09:33:15 +0200 [thread overview]
Message-ID: <20160621073315.GA13670@krava> (raw)
In-Reply-To: <1465380938-64371-1-git-send-email-hekuang@huawei.com>
On Wed, Jun 08, 2016 at 10:15:35AM +0000, He Kuang wrote:
> The remote unwind can supported scenario where we collect on a x86_64
> machine and want to do analysis on a ARM64 or x86-32 machine. Though
> this is not tested, after Arnaldo questioned the above issue, I tested
> and found a bug.
>
> In util/unwind-libunwind-local.c, PERF_REG_SP/IP is used, but those
> macros are assigned to the host platform, we should redefine them in
> the wrapper file, for example in "util/libunwind/x86_32.c".
>
> After fixing this problem, i686 perf.data can be parsed on aarch64
> machine.
>
> To Arnaldo, I noticed that this patch
> "perf tools: Find vdso supporting cross-platform analysis"
> is not on "origin/perf/unwind" branch, this patch was applied, please
> check if it was missed, the above test needs this patch.
>
> Thank you.
>
> He Kuang (3):
> perf unwind: Change macro names of perf register
> perf unwind: Fix wrongly used regs for x86_32 unwind
> perf unwind: Fix wrongly used regs for aarch64 unwind
for the patchset:
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
prev parent reply other threads:[~2016-06-21 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 10:15 [PATCH 0/3] Fixes on remote unwind He Kuang
2016-06-08 10:15 ` [PATCH 1/3] perf unwind: Change macro names of perf register He Kuang
2016-06-08 10:15 ` [PATCH 2/3] perf unwind: Fix wrongly used regs for x86_32 unwind He Kuang
2016-06-08 10:15 ` [PATCH 3/3] perf unwind: Fix wrongly used regs for aarch64 unwind He Kuang
2016-06-12 10:03 ` [PATCH 0/3] Fixes on remote unwind Hekuang
2016-06-21 1:59 ` Hekuang
2016-06-21 7:33 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621073315.GA13670@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=hekuang@huawei.com \
--cc=jpoimboe@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=tumanova@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).