From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: rtc-linux@googlegroups.com,
Alessandro Zummo <a.zummo@towertech.it>,
linux-kernel@vger.kernel.org, cphealy@gmail.com
Subject: Re: [PATCH v2 00/17] DS1341 support and code cleanup
Date: Tue, 21 Jun 2016 23:32:19 +0200 [thread overview]
Message-ID: <20160621213219.GC5809@piout.net> (raw)
In-Reply-To: <1466493519-11277-1-git-send-email-andrew.smirnov@gmail.com>
Hi,
On 21/06/2016 at 00:18:22 -0700, Andrey Smirnov wrote :
> Hi everyone,
>
> This set is a v2 of the DS1307 driver patches. Changes since v1:
>
> - Devicetree bindings are separated into a separate commit
>
> - Device tree properties now have vendor specific prefixes and
> documenatation explicitly stating their type
>
> - Three more patches, with improvements to rtctest.c, are added to
> the patchset
>
> Any feedback is appreciated.
>
> Thank you,
> Andrey Smirnov
>
> Andrey Smirnov (17):
> RTC: ds1307: Add DS1341 variant
> RTC: ds1307: Disable square wave and timers as default
> RTC: ds1307: Add devicetree bindings for DS1341
> RTC: ds1307: Add DS1341 specific power-saving options
> RTC: ds1307: Convert ds1307_can_wakeup_device into a predicate
> RTC: ds1307: Convert want_irq into a predicate
I'll have to triple check that one, it breaks in thousand different
ways, every time someone touches that code :)
> RTC: ds1307: Move chip configuration into a separate routine
> RTC: ds1307: Move chip sanity checking into a separate routine
I'm not sure about the cleanup in those two patches yet, It moves a lot
of code and the readability improvement is not obvious
> RTC: ds1307: Remove register "cache"
> RTC: ds1307: Constify struct ds1307 where possible
> RTC: ds1307: Convert goto to a loop
> RTC: ds1307: Redefine RX8025_REG_* to minimize extra code
> RTC: ds1307: Report oscillator problems more intelligently
> RTC: ds1307: Move last bits of sanity checking out of chip_configure
> RTC: rtctest: Change alarm IRQ support detection
> RTC: rtctest: Change no IRQ detection for RTC_IRQP_READ
> RTC: rtctest: Change no IRQ detection for RTC_IRQP_SET
I already had patches for that issue in a development tree, I'll see if
they match what I did.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-06-21 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 7:18 [PATCH v2 00/17] DS1341 support and code cleanup Andrey Smirnov
2016-06-21 21:32 ` Alexandre Belloni [this message]
2016-06-21 23:51 ` Andrey Smirnov
2016-06-26 13:30 ` Alexandre Belloni
-- strict thread matches above, loose matches on Subject: below --
2016-06-21 7:14 Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621213219.GC5809@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).