From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: rtc-linux@googlegroups.com,
Alessandro Zummo <a.zummo@towertech.it>,
linux-kernel@vger.kernel.org, Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH v2 00/17] DS1341 support and code cleanup
Date: Tue, 21 Jun 2016 16:51:26 -0700 [thread overview]
Message-ID: <CAHQ1cqHyw8BXxpMVRmFTUP9HUy6TAau48wZc3=XJB8ZexuVkjw@mail.gmail.com> (raw)
In-Reply-To: <20160621213219.GC5809@piout.net>
>>
>> Andrey Smirnov (17):
>> RTC: ds1307: Add DS1341 variant
>> RTC: ds1307: Disable square wave and timers as default
>> RTC: ds1307: Add devicetree bindings for DS1341
>> RTC: ds1307: Add DS1341 specific power-saving options
>> RTC: ds1307: Convert ds1307_can_wakeup_device into a predicate
>> RTC: ds1307: Convert want_irq into a predicate
>
> I'll have to triple check that one, it breaks in thousand different
> ways, every time someone touches that code :)
Wouldn't you agree that this might be an indication that the code is a
bit convoluted and some cleanup is in order? ;-)
>
>> RTC: ds1307: Move chip configuration into a separate routine
>> RTC: ds1307: Move chip sanity checking into a separate routine
>
> I'm not sure about the cleanup in those two patches yet, It moves a lot
> of code and the readability improvement is not obvious
OK, I agree that this patch moves a lot of code, and can't really
argue with "not obvious" since that is subjective. Please let me know
what you decide and I'll change v3 appropriately.
Thanks,
Andrey
next prev parent reply other threads:[~2016-06-21 23:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 7:18 [PATCH v2 00/17] DS1341 support and code cleanup Andrey Smirnov
2016-06-21 21:32 ` Alexandre Belloni
2016-06-21 23:51 ` Andrey Smirnov [this message]
2016-06-26 13:30 ` Alexandre Belloni
-- strict thread matches above, loose matches on Subject: below --
2016-06-21 7:14 Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHQ1cqHyw8BXxpMVRmFTUP9HUy6TAau48wZc3=XJB8ZexuVkjw@mail.gmail.com' \
--to=andrew.smirnov@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=cphealy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).