From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: luoyi.ly@gmail.com
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, wens@csie.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH V3] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Date: Wed, 22 Jun 2016 11:57:23 +0200 [thread overview]
Message-ID: <20160622095723.GU26668@lukather> (raw)
In-Reply-To: <20160617095602.14612-1-luoyi.ly@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
Hi,
On Fri, Jun 17, 2016 at 05:56:02PM +0800, luoyi.ly@gmail.com wrote:
> From: Luo Yi <luoyi.ly@gmail.com>
>
> Add support for the Bananapi M1 Plus A20 development board from
> sinovoip.com.cn . This board is nearly a clone of the Lemaker's
> Bananapro, but differ with the wlan chipset connection and i2s pinout.
> And I also enable the integrated audio codec on default.
This patch content is fine, but there's a lot of small issues:
- You're not indenting the nodes properly
- You're missing your Signed-off-by tag
- And probably other stuff
This has all been reported by checkpatch.
Make sure you run checkpatch, make the modifications needed so that
you don't have any warnings or errors anymore, and resubmit it.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-22 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 9:56 [PATCH V3] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board luoyi.ly
2016-06-22 9:57 ` Maxime Ripard [this message]
2016-06-24 6:11 ` luoyi.ly
2016-06-25 7:47 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622095723.GU26668@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@arm.linux.org.uk \
--cc=luoyi.ly@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).