[PATCH] w1: Remove unneeded header file

[PATCH] w1: Remove unneeded header file

[Amitoj Kaur Chawla]

Drop redundant include of moduleparam.h

The Coccinelle semantic patch used to make this change is as follows:
@ includesmodule @
@@

#include <linux/module.h>

@ depends on includesmodule @
@@

- #include <linux/moduleparam.h>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/w1/w1.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 89a7847..a02361d 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -22,7 +22,6 @@
 #include <linux/delay.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/moduleparam.h>
 #include <linux/list.h>
 #include <linux/interrupt.h>
 #include <linux/spinlock.h>
-- 
1.9.1

Re: [PATCH] w1: Remove unneeded header file

[Evgeniy Polyakov]

Hi

24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@gmail.com>:
> Drop redundant include of moduleparam.h
>
> The Coccinelle semantic patch used to make this change is as follows:
> @ includesmodule @
> @@
>
> #include <linux/module.h>
>
> @ depends on includesmodule @
> @@
>
> - #include <linux/moduleparam.h>
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>

Looks good to me, but these @@ are pretty cryptic.

Re: [PATCH] w1: Remove unneeded header file

[Julia Lawall]

On Tue, 28 Jun 2016, Evgeniy Polyakov wrote:

> Hi
>
> 24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@gmail.com>:
> > Drop redundant include of moduleparam.h
> >
> > The Coccinelle semantic patch used to make this change is as follows:
> > @ includesmodule @
> > @@
> >
> > #include <linux/module.h>
> >
> > @ depends on includesmodule @
> > @@
> >
> > - #include <linux/moduleparam.h>
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
>
> Looks good to me, but these @@ are pretty cryptic.

There are two rules.  The first checks for an include of module.h.  The
second depends on the success of the first one.  It removes and include o
moduleparam.h.

julia

Re: [PATCH] w1: Remove unneeded header file

[Evgeniy Polyakov]

Hi

28.06.2016, 16:50, "Julia Lawall" <julia.lawall@lip6.fr>:
>>  24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@gmail.com>:
>>  > The Coccinelle semantic patch used to make this change is as follows:
>>  > @ includesmodule @
>>  > @@
>>  >
>>  > #include <linux/module.h>
>>  >
>>  > @ depends on includesmodule @
>>  > @@
>>  >
>>  > - #include <linux/moduleparam.h>
>>  >
>>  > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
>>
>>  Looks good to me, but these @@ are pretty cryptic.
>
> There are two rules. The first checks for an include of module.h. The
> second depends on the success of the first one. It removes and include o
> moduleparam.h.

Ok, I see, it makes much more sense now :)

Thank you for clarification