From: Tejun Heo <tj@kernel.org>
To: Aleksa Sarai <asarai@suse.de>
Cc: Jonathan Corbet <corbet@lwn.net>, Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>, Kenny Yu <kennyyu@fb.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH 1/2] cgroup: pids: show number of failed forks since limit reset
Date: Fri, 24 Jun 2016 11:31:51 -0400 [thread overview]
Message-ID: <20160624153151.GQ3262@mtj.duckdns.org> (raw)
In-Reply-To: <20160624030049.13341-2-asarai@suse.de>
Hello,
On Fri, Jun 24, 2016 at 01:00:48PM +1000, Aleksa Sarai wrote:
> This allows users to dynamically adjust their limits based on how many
> failed forks happened since they last reset their limits, otherwise they
> would have to track (in a racy way) how many limit failures there were
> since the last limit change manually. In addition, we log the first
> failure since the limit was reset (which was the original semantics of
> the patchset).
Isn't that trivially achievable by reading the counter and then
calculating the diff? I don't think it matters all that much whether
the log message is printed once per cgroup or per config-change. It's
just a hint for the admin to avoid setting her off on a wild goose
chase.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-06-24 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 3:00 [PATCH 0/2] cgroup: pids: extend pids.events Aleksa Sarai
2016-06-24 3:00 ` [PATCH 1/2] cgroup: pids: show number of failed forks since limit reset Aleksa Sarai
2016-06-24 3:00 ` [PATCH 2/2] docs: cgroup/pids: update documentation to include pids.events Aleksa Sarai
2016-06-24 15:31 ` Tejun Heo [this message]
2016-06-26 11:34 ` [PATCH 1/2] cgroup: pids: show number of failed forks since limit reset Aleksa Sarai
2016-06-26 23:42 ` Tejun Heo
2016-06-29 5:10 ` Aleksa Sarai
2016-06-29 15:33 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624153151.GQ3262@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=asarai@suse.de \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=kennyyu@fb.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).