* [PATCH 1/1] i40iw: do not print unitialized variables in error message
@ 2016-06-25 15:55 Nicolas Iooss
2016-07-12 14:59 ` Doug Ledford
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Iooss @ 2016-06-25 15:55 UTC (permalink / raw)
To: Faisal Latif, Chien Tin Tung, Mustafa Ismail, Shiraz Saleem,
Tatyana Nikolova
Cc: linux-rdma, linux-kernel, Nicolas Iooss
i40iw_create_cqp() printed the contents of variables maj_err and min_err
in an error message before they could be initialized (by calling
dev->cqp_ops->cqp_create).
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
drivers/infiniband/hw/i40iw/i40iw_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/i40iw/i40iw_main.c b/drivers/infiniband/hw/i40iw/i40iw_main.c
index c963cad92f5a..6e9081380a27 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_main.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_main.c
@@ -600,8 +600,7 @@ static enum i40iw_status_code i40iw_create_cqp(struct i40iw_device *iwdev)
cqp_init_info.scratch_array = cqp->scratch_array;
status = dev->cqp_ops->cqp_init(dev->cqp, &cqp_init_info);
if (status) {
- i40iw_pr_err("cqp init status %d maj_err %d min_err %d\n",
- status, maj_err, min_err);
+ i40iw_pr_err("cqp init status %d\n", status);
goto exit;
}
status = dev->cqp_ops->cqp_create(dev->cqp, true, &maj_err, &min_err);
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] i40iw: do not print unitialized variables in error message
2016-06-25 15:55 [PATCH 1/1] i40iw: do not print unitialized variables in error message Nicolas Iooss
@ 2016-07-12 14:59 ` Doug Ledford
0 siblings, 0 replies; 2+ messages in thread
From: Doug Ledford @ 2016-07-12 14:59 UTC (permalink / raw)
To: Nicolas Iooss, Faisal Latif, Chien Tin Tung, Mustafa Ismail,
Shiraz Saleem, Tatyana Nikolova
Cc: linux-rdma, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 378 bytes --]
On 6/25/2016 11:55 AM, Nicolas Iooss wrote:
> i40iw_create_cqp() printed the contents of variables maj_err and min_err
> in an error message before they could be initialized (by calling
> dev->cqp_ops->cqp_create).
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Applied, thanks.
--
Doug Ledford <dledford@redhat.com>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-12 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-25 15:55 [PATCH 1/1] i40iw: do not print unitialized variables in error message Nicolas Iooss
2016-07-12 14:59 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).