* [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models [not found] <20160625091522.GA6423@eudyptula.hq.kempniu.pl> @ 2016-06-26 7:41 ` Michał Kępień 2016-06-27 8:03 ` [PATCH] Register KEY_TOUCHPAD_TOGGLE with input device Jan-Marek Glogowski 2016-06-27 12:48 ` [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Jonathan Woithe 0 siblings, 2 replies; 9+ messages in thread From: Michał Kępień @ 2016-06-26 7:41 UTC (permalink / raw) To: Jonathan Woithe, Darren Hart, Jan-Marek Glogowski Cc: platform-driver-x86, linux-kernel Haswell-based Fujitsu laptops (Lifebook E734/E744/E754) have a touchpad toggle hotkey (Fn+F4) which is handled transparently to the operating system: while an ACPI notification is sent to FUJ02B1 when Fn+F4 is pressed, touchpad state is properly toggled without any explicit support for this operation in fujitsu-laptop. Skylake-based models (Lifebook E736/E746/E756) also have that hotkey, but the touchpad is not toggled transparently to the operating system. When Fn+F4 is pressed, an ACPI notification is sent to FUJ02E3. A subsequent call to S000 (FUNC_RFKILL) can be used to determine whether the touchpad toggle hotkey was pressed so that an input event can be sent to userspace. Relevant ACPI code: Method (_L21, 0, NotSerialized) { ... If (AHKF) { Notify (\_SB.FEXT, 0x80) } ... } Method (S000, 3, Serialized) { Name (_T_0, Zero) Local0 = Zero While (One) { _T_0 = Arg0 If (_T_0 == Zero) { Local0 |= 0x04000000 Local0 |= 0x02000000 Local0 |= 0x00020000 Local0 |= 0x0200 Local0 |= 0x0100 Local0 |= 0x20 } ElseIf (_T_0 == One) { ... If (AHKF & 0x08) { Local0 |= 0x04000000 AHKF ^= 0x08 } ... } ... Break } Return (Local0) } Pressing Fn+F4 raises GPE 0x21 and sets bit 3 in AHKF. This in turn results in bit 26 being set in the value returned by FUNC_RFKILL called with 1 as its first argument. On Skylake-based models, bit 26 is also set in the value returned by FUNC_RFKILL called with 0 as its first argument (this value is saved in fujitsu_hotkey->rfkill_supported upon module initialization), which suggests that this bit is set on models which do not handle touchpad toggling transparently to the operating system. Note that bit 3 is cleared in AHKF once FUNC_RFKILL is called with 1 as its first argument, which requires fujitsu-laptop to handle this hotkey in a different manner than the other, GIRB-based hotkeys: two input events (press and release) are immediately sent once Fn+F4 is pressed. Reported-by: Jan-Marek Glogowski <glogow@fbihome.de> Signed-off-by: Michał Kępień <kernel@kempniu.pl> --- Darren, this patch needs both an Acked-by from Jonathan and a Tested-by from Jan-Marek before merging as I do not have the hardware to test it. drivers/platform/x86/fujitsu-laptop.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index ce41bc3..ef28447 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -1060,6 +1060,15 @@ static void acpi_fujitsu_hotkey_notify(struct acpi_device *device, u32 event) } } + if ((fujitsu_hotkey->rfkill_supported & BIT(26)) && + (call_fext_func(FUNC_RFKILL, 0x1, 0x0, 0x0) & BIT(26))) { + keycode = KEY_TOUCHPAD_TOGGLE; + input_report_key(input, keycode, 1); + input_sync(input); + input_report_key(input, keycode, 0); + input_sync(input); + } + break; default: keycode = KEY_UNKNOWN; -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] Register KEY_TOUCHPAD_TOGGLE with input device 2016-06-26 7:41 ` [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Michał Kępień @ 2016-06-27 8:03 ` Jan-Marek Glogowski 2016-06-27 12:48 ` [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Jonathan Woithe 1 sibling, 0 replies; 9+ messages in thread From: Jan-Marek Glogowski @ 2016-06-27 8:03 UTC (permalink / raw) To: Michał Kępień, Jonathan Woithe, Darren Hart Cc: platform-driver-x86, linux-kernel Probably just squash that into [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Signed-off-by: Jan-Marek Glogowski <glogow@fbihome.de> --- fujitsu-laptop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index 695bd5e..42319c8 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -884,6 +884,7 @@ static int acpi_fujitsu_hotkey_add(struct acpi_device *device) set_bit(fujitsu->keycode3, input->keybit); set_bit(fujitsu->keycode4, input->keybit); set_bit(fujitsu->keycode5, input->keybit); + set_bit(KEY_TOUCHPAD_TOGGLE, input->keybit); set_bit(KEY_UNKNOWN, input->keybit); error = input_register_device(input); -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models 2016-06-26 7:41 ` [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Michał Kępień 2016-06-27 8:03 ` [PATCH] Register KEY_TOUCHPAD_TOGGLE with input device Jan-Marek Glogowski @ 2016-06-27 12:48 ` Jonathan Woithe 2016-06-27 12:55 ` Michał Kępień 2016-06-27 13:19 ` [PATCH v2] " Michał Kępień 1 sibling, 2 replies; 9+ messages in thread From: Jonathan Woithe @ 2016-06-27 12:48 UTC (permalink / raw) To: Micha?? K??pie?? Cc: Darren Hart, Jan-Marek Glogowski, platform-driver-x86, linux-kernel On Sun, Jun 26, 2016 at 09:41:35AM +0200, Micha?? K??pie?? wrote: > Haswell-based Fujitsu laptops (Lifebook E734/E744/E754) have a touchpad > toggle hotkey (Fn+F4) which is handled transparently to the operating > system: while an ACPI notification is sent to FUJ02B1 when Fn+F4 is > pressed, touchpad state is properly toggled without any explicit support > for this operation in fujitsu-laptop. > : I am happy with the patch code once the one-line fix from Jan-Marek is included. However, given the rather non-intuitive behaviour that the patch is dealing with I wonder whether a short (2 line) comment in the code might be justified. There is otherwise no obvious reason why the touchpad button code must interact with the rf kill hardware. Please respin the patch with the above in mind (and inlude Jan-Marek's fix). Regards jonathan > Skylake-based models (Lifebook E736/E746/E756) also have that hotkey, > but the touchpad is not toggled transparently to the operating system. > When Fn+F4 is pressed, an ACPI notification is sent to FUJ02E3. A > subsequent call to S000 (FUNC_RFKILL) can be used to determine whether > the touchpad toggle hotkey was pressed so that an input event can be > sent to userspace. > > Relevant ACPI code: > > Method (_L21, 0, NotSerialized) > { > ... > If (AHKF) > { > Notify (\_SB.FEXT, 0x80) > } > ... > } > > Method (S000, 3, Serialized) > { > Name (_T_0, Zero) > Local0 = Zero > While (One) > { > _T_0 = Arg0 > If (_T_0 == Zero) > { > Local0 |= 0x04000000 > Local0 |= 0x02000000 > Local0 |= 0x00020000 > Local0 |= 0x0200 > Local0 |= 0x0100 > Local0 |= 0x20 > } > ElseIf (_T_0 == One) > { > ... > If (AHKF & 0x08) > { > Local0 |= 0x04000000 > AHKF ^= 0x08 > } > ... > } ... > Break > } > Return (Local0) > } > > Pressing Fn+F4 raises GPE 0x21 and sets bit 3 in AHKF. This in turn > results in bit 26 being set in the value returned by FUNC_RFKILL called > with 1 as its first argument. On Skylake-based models, bit 26 is also > set in the value returned by FUNC_RFKILL called with 0 as its first > argument (this value is saved in fujitsu_hotkey->rfkill_supported upon > module initialization), which suggests that this bit is set on models > which do not handle touchpad toggling transparently to the operating > system. > > Note that bit 3 is cleared in AHKF once FUNC_RFKILL is called with 1 as > its first argument, which requires fujitsu-laptop to handle this hotkey > in a different manner than the other, GIRB-based hotkeys: two input > events (press and release) are immediately sent once Fn+F4 is pressed. > > Reported-by: Jan-Marek Glogowski <glogow@fbihome.de> > Signed-off-by: Micha?? K??pie?? <kernel@kempniu.pl> > --- > > Darren, this patch needs both an Acked-by from Jonathan and a Tested-by > from Jan-Marek before merging as I do not have the hardware to test it. > > drivers/platform/x86/fujitsu-laptop.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c > index ce41bc3..ef28447 100644 > --- a/drivers/platform/x86/fujitsu-laptop.c > +++ b/drivers/platform/x86/fujitsu-laptop.c > @@ -1060,6 +1060,15 @@ static void acpi_fujitsu_hotkey_notify(struct acpi_device *device, u32 event) > } > } > > + if ((fujitsu_hotkey->rfkill_supported & BIT(26)) && > + (call_fext_func(FUNC_RFKILL, 0x1, 0x0, 0x0) & BIT(26))) { > + keycode = KEY_TOUCHPAD_TOGGLE; > + input_report_key(input, keycode, 1); > + input_sync(input); > + input_report_key(input, keycode, 0); > + input_sync(input); > + } > + > break; > default: > keycode = KEY_UNKNOWN; > -- > 1.7.10.4 -- ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models 2016-06-27 12:48 ` [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Jonathan Woithe @ 2016-06-27 12:55 ` Michał Kępień 2016-06-27 13:19 ` [PATCH v2] " Michał Kępień 1 sibling, 0 replies; 9+ messages in thread From: Michał Kępień @ 2016-06-27 12:55 UTC (permalink / raw) To: Jonathan Woithe Cc: Darren Hart, Jan-Marek Glogowski, platform-driver-x86, linux-kernel > > Haswell-based Fujitsu laptops (Lifebook E734/E744/E754) have a touchpad > > toggle hotkey (Fn+F4) which is handled transparently to the operating > > system: while an ACPI notification is sent to FUJ02B1 when Fn+F4 is > > pressed, touchpad state is properly toggled without any explicit support > > for this operation in fujitsu-laptop. > > : > > I am happy with the patch code once the one-line fix from Jan-Marek is > included. However, given the rather non-intuitive behaviour that the patch > is dealing with I wonder whether a short (2 line) comment in the code might > be justified. There is otherwise no obvious reason why the touchpad button > code must interact with the rf kill hardware. > > Please respin the patch with the above in mind (and inlude Jan-Marek's fix). Will do, thanks for the review. -- Best regards, Michał Kępień ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models 2016-06-27 12:48 ` [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Jonathan Woithe 2016-06-27 12:55 ` Michał Kępień @ 2016-06-27 13:19 ` Michał Kępień 2016-06-28 1:06 ` Jonathan Woithe 1 sibling, 1 reply; 9+ messages in thread From: Michał Kępień @ 2016-06-27 13:19 UTC (permalink / raw) To: Jonathan Woithe, Darren Hart Cc: Jan-Marek Glogowski, platform-driver-x86, linux-kernel Haswell-based Fujitsu laptops (Lifebook E734/E744/E754) have a touchpad toggle hotkey (Fn+F4) which is handled transparently to the operating system: while an ACPI notification is sent to FUJ02B1 when Fn+F4 is pressed, touchpad state is properly toggled without any explicit support for this operation in fujitsu-laptop. Skylake-based models (Lifebook E736/E746/E756) also have that hotkey, but the touchpad is not toggled transparently to the operating system. When Fn+F4 is pressed, an ACPI notification is sent to FUJ02E3. A subsequent call to S000 (FUNC_RFKILL) can be used to determine whether the touchpad toggle hotkey was pressed so that an input event can be sent to userspace. Relevant ACPI code: Method (_L21, 0, NotSerialized) { ... If (AHKF) { Notify (\_SB.FEXT, 0x80) } ... } Method (S000, 3, Serialized) { Name (_T_0, Zero) Local0 = Zero While (One) { _T_0 = Arg0 If (_T_0 == Zero) { Local0 |= 0x04000000 Local0 |= 0x02000000 Local0 |= 0x00020000 Local0 |= 0x0200 Local0 |= 0x0100 Local0 |= 0x20 } ElseIf (_T_0 == One) { ... If (AHKF & 0x08) { Local0 |= 0x04000000 AHKF ^= 0x08 } ... } ... Break } Return (Local0) } Pressing Fn+F4 raises GPE 0x21 and sets bit 3 in AHKF. This in turn results in bit 26 being set in the value returned by FUNC_RFKILL called with 1 as its first argument. On Skylake-based models, bit 26 is also set in the value returned by FUNC_RFKILL called with 0 as its first argument (this value is saved in fujitsu_hotkey->rfkill_supported upon module initialization), which suggests that this bit is set on models which do not handle touchpad toggling transparently to the operating system. Note that bit 3 is cleared in AHKF once FUNC_RFKILL is called with 1 as its first argument, which requires fujitsu-laptop to handle this hotkey in a different manner than the other, GIRB-based hotkeys: two input events (press and release) are immediately sent once Fn+F4 is pressed. Reported-and-tested-by: Jan-Marek Glogowski <glogow@fbihome.de> Signed-off-by: Michał Kępień <kernel@kempniu.pl> --- Changes from v1: - added KEY_TOUCHPAD_TOGGLE to the FUJ02E3 input device's key bitmap, - added code comment. drivers/platform/x86/fujitsu-laptop.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index ce41bc3..37ef75e 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -856,6 +856,7 @@ static int acpi_fujitsu_hotkey_add(struct acpi_device *device) set_bit(fujitsu->keycode3, input->keybit); set_bit(fujitsu->keycode4, input->keybit); set_bit(fujitsu->keycode5, input->keybit); + set_bit(KEY_TOUCHPAD_TOGGLE, input->keybit); set_bit(KEY_UNKNOWN, input->keybit); error = input_register_device(input); @@ -1060,6 +1061,18 @@ static void acpi_fujitsu_hotkey_notify(struct acpi_device *device, u32 event) } } + /* On some models, the touchpad toggle hotkey (Fn+F4) is + * handled in software; its state is queried using FUNC_RFKILL + */ + if ((fujitsu_hotkey->rfkill_supported & BIT(26)) && + (call_fext_func(FUNC_RFKILL, 0x1, 0x0, 0x0) & BIT(26))) { + keycode = KEY_TOUCHPAD_TOGGLE; + input_report_key(input, keycode, 1); + input_sync(input); + input_report_key(input, keycode, 0); + input_sync(input); + } + break; default: keycode = KEY_UNKNOWN; -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models 2016-06-27 13:19 ` [PATCH v2] " Michał Kępień @ 2016-06-28 1:06 ` Jonathan Woithe 2016-06-28 7:25 ` [PATCH v3] " Michał Kępień 0 siblings, 1 reply; 9+ messages in thread From: Jonathan Woithe @ 2016-06-28 1:06 UTC (permalink / raw) To: Micha?? K??pie?? Cc: Darren Hart, Jan-Marek Glogowski, platform-driver-x86, linux-kernel On Mon, Jun 27, 2016 at 03:19:41PM +0200, Micha?? K??pie?? wrote: > Haswell-based Fujitsu laptops (Lifebook E734/E744/E754) have a touchpad > toggle hotkey (Fn+F4) which is handled transparently to the operating > system: while an ACPI notification is sent to FUJ02B1 when Fn+F4 is > pressed, touchpad state is properly toggled without any explicit support > for this operation in fujitsu-laptop. > > Skylake-based models (Lifebook E736/E746/E756) also have that hotkey, > but the touchpad is not toggled transparently to the operating system. > : > Reported-and-tested-by: Jan-Marek Glogowski <glogow@fbihome.de> > Signed-off-by: Micha?? K??pie?? <kernel@kempniu.pl> A nitpick: in the patch, rather than "some models", perhaps explicitly mention some of them. For example: On some models (first seen on the Skylake-based Lifebook E736/E746/E756), the touchpad ... I know this pushes the comment to 3 lines, but it results in a solid indication in the code as to where and why the change was first needed. Otherwise, all good. Regards jonathan > --- > > Changes from v1: > > - added KEY_TOUCHPAD_TOGGLE to the FUJ02E3 input device's key bitmap, > > - added code comment. > > drivers/platform/x86/fujitsu-laptop.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c > index ce41bc3..37ef75e 100644 > --- a/drivers/platform/x86/fujitsu-laptop.c > +++ b/drivers/platform/x86/fujitsu-laptop.c > @@ -856,6 +856,7 @@ static int acpi_fujitsu_hotkey_add(struct acpi_device *device) > set_bit(fujitsu->keycode3, input->keybit); > set_bit(fujitsu->keycode4, input->keybit); > set_bit(fujitsu->keycode5, input->keybit); > + set_bit(KEY_TOUCHPAD_TOGGLE, input->keybit); > set_bit(KEY_UNKNOWN, input->keybit); > > error = input_register_device(input); > @@ -1060,6 +1061,18 @@ static void acpi_fujitsu_hotkey_notify(struct acpi_device *device, u32 event) > } > } > > + /* On some models, the touchpad toggle hotkey (Fn+F4) is > + * handled in software; its state is queried using FUNC_RFKILL > + */ > + if ((fujitsu_hotkey->rfkill_supported & BIT(26)) && > + (call_fext_func(FUNC_RFKILL, 0x1, 0x0, 0x0) & BIT(26))) { > + keycode = KEY_TOUCHPAD_TOGGLE; > + input_report_key(input, keycode, 1); > + input_sync(input); > + input_report_key(input, keycode, 0); > + input_sync(input); > + } > + > break; > default: > keycode = KEY_UNKNOWN; > -- > 1.7.10.4 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models 2016-06-28 1:06 ` Jonathan Woithe @ 2016-06-28 7:25 ` Michał Kępień 2016-06-28 11:19 ` Jonathan Woithe 0 siblings, 1 reply; 9+ messages in thread From: Michał Kępień @ 2016-06-28 7:25 UTC (permalink / raw) To: Jonathan Woithe, Darren Hart Cc: Jan-Marek Glogowski, platform-driver-x86, linux-kernel Haswell-based Fujitsu laptops (Lifebook E734/E744/E754) have a touchpad toggle hotkey (Fn+F4) which is handled transparently to the operating system: while an ACPI notification is sent to FUJ02B1 when Fn+F4 is pressed, touchpad state is properly toggled without any explicit support for this operation in fujitsu-laptop. Skylake-based models (Lifebook E736/E746/E756) also have that hotkey, but the touchpad is not toggled transparently to the operating system. When Fn+F4 is pressed, an ACPI notification is sent to FUJ02E3. A subsequent call to S000 (FUNC_RFKILL) can be used to determine whether the touchpad toggle hotkey was pressed so that an input event can be sent to userspace. Relevant ACPI code: Method (_L21, 0, NotSerialized) { ... If (AHKF) { Notify (\_SB.FEXT, 0x80) } ... } Method (S000, 3, Serialized) { Name (_T_0, Zero) Local0 = Zero While (One) { _T_0 = Arg0 If (_T_0 == Zero) { Local0 |= 0x04000000 Local0 |= 0x02000000 Local0 |= 0x00020000 Local0 |= 0x0200 Local0 |= 0x0100 Local0 |= 0x20 } ElseIf (_T_0 == One) { ... If (AHKF & 0x08) { Local0 |= 0x04000000 AHKF ^= 0x08 } ... } ... Break } Return (Local0) } Pressing Fn+F4 raises GPE 0x21 and sets bit 3 in AHKF. This in turn results in bit 26 being set in the value returned by FUNC_RFKILL called with 1 as its first argument. On Skylake-based models, bit 26 is also set in the value returned by FUNC_RFKILL called with 0 as its first argument (this value is saved in fujitsu_hotkey->rfkill_supported upon module initialization), which suggests that this bit is set on models which do not handle touchpad toggling transparently to the operating system. Note that bit 3 is cleared in AHKF once FUNC_RFKILL is called with 1 as its first argument, which requires fujitsu-laptop to handle this hotkey in a different manner than the other, GIRB-based hotkeys: two input events (press and release) are immediately sent once Fn+F4 is pressed. Reported-and-tested-by: Jan-Marek Glogowski <glogow@fbihome.de> Signed-off-by: Michał Kępień <kernel@kempniu.pl> --- Changes from v2: - edited code comment so that it defines "some models" more precisely. Changes from v1: - added KEY_TOUCHPAD_TOGGLE to the FUJ02E3 input device's key bitmap, - added code comment. drivers/platform/x86/fujitsu-laptop.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index ce41bc3..36cd743 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -856,6 +856,7 @@ static int acpi_fujitsu_hotkey_add(struct acpi_device *device) set_bit(fujitsu->keycode3, input->keybit); set_bit(fujitsu->keycode4, input->keybit); set_bit(fujitsu->keycode5, input->keybit); + set_bit(KEY_TOUCHPAD_TOGGLE, input->keybit); set_bit(KEY_UNKNOWN, input->keybit); error = input_register_device(input); @@ -1060,6 +1061,19 @@ static void acpi_fujitsu_hotkey_notify(struct acpi_device *device, u32 event) } } + /* On some models (first seen on the Skylake-based Lifebook + * E736/E746/E756), the touchpad toggle hotkey (Fn+F4) is + * handled in software; its state is queried using FUNC_RFKILL + */ + if ((fujitsu_hotkey->rfkill_supported & BIT(26)) && + (call_fext_func(FUNC_RFKILL, 0x1, 0x0, 0x0) & BIT(26))) { + keycode = KEY_TOUCHPAD_TOGGLE; + input_report_key(input, keycode, 1); + input_sync(input); + input_report_key(input, keycode, 0); + input_sync(input); + } + break; default: keycode = KEY_UNKNOWN; -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models 2016-06-28 7:25 ` [PATCH v3] " Michał Kępień @ 2016-06-28 11:19 ` Jonathan Woithe 2016-06-28 17:50 ` Darren Hart 0 siblings, 1 reply; 9+ messages in thread From: Jonathan Woithe @ 2016-06-28 11:19 UTC (permalink / raw) To: Micha?? K??pie?? Cc: Darren Hart, Jan-Marek Glogowski, platform-driver-x86, linux-kernel On Tue, Jun 28, 2016 at 09:25:50AM +0200, Micha?? K??pie?? wrote: > Haswell-based Fujitsu laptops (Lifebook E734/E744/E754) have a touchpad > toggle hotkey (Fn+F4) which is handled transparently to the operating > system: while an ACPI notification is sent to FUJ02B1 when Fn+F4 is > pressed, touchpad state is properly toggled without any explicit support > for this operation in fujitsu-laptop. > > Skylake-based models (Lifebook E736/E746/E756) also have that hotkey, > but the touchpad is not toggled transparently to the operating system. > When Fn+F4 is pressed, an ACPI notification is sent to FUJ02E3. A > subsequent call to S000 (FUNC_RFKILL) can be used to determine whether > the touchpad toggle hotkey was pressed so that an input event can be > sent to userspace. > > Relevant ACPI code: > > Method (_L21, 0, NotSerialized) > { > ... > If (AHKF) > { > Notify (\_SB.FEXT, 0x80) > } > ... > } > > Method (S000, 3, Serialized) > { > Name (_T_0, Zero) > Local0 = Zero > While (One) > { > _T_0 = Arg0 > If (_T_0 == Zero) > { > Local0 |= 0x04000000 > Local0 |= 0x02000000 > Local0 |= 0x00020000 > Local0 |= 0x0200 > Local0 |= 0x0100 > Local0 |= 0x20 > } > ElseIf (_T_0 == One) > { > ... > If (AHKF & 0x08) > { > Local0 |= 0x04000000 > AHKF ^= 0x08 > } > ... > } ... > Break > } > Return (Local0) > } > > Pressing Fn+F4 raises GPE 0x21 and sets bit 3 in AHKF. This in turn > results in bit 26 being set in the value returned by FUNC_RFKILL called > with 1 as its first argument. On Skylake-based models, bit 26 is also > set in the value returned by FUNC_RFKILL called with 0 as its first > argument (this value is saved in fujitsu_hotkey->rfkill_supported upon > module initialization), which suggests that this bit is set on models > which do not handle touchpad toggling transparently to the operating > system. > > Note that bit 3 is cleared in AHKF once FUNC_RFKILL is called with 1 as > its first argument, which requires fujitsu-laptop to handle this hotkey > in a different manner than the other, GIRB-based hotkeys: two input > events (press and release) are immediately sent once Fn+F4 is pressed. > > Reported-and-tested-by: Jan-Marek Glogowski <glogow@fbihome.de> > Signed-off-by: Micha?? K??pie?? <kernel@kempniu.pl> Thanks for the revision and your patience. Acked-by: Jonathan Woithe <jwoithe@just42.net> Regards jonathan > --- > > Changes from v2: > > - edited code comment so that it defines "some models" more precisely. > > Changes from v1: > > - added KEY_TOUCHPAD_TOGGLE to the FUJ02E3 input device's key bitmap, > > - added code comment. > > drivers/platform/x86/fujitsu-laptop.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c > index ce41bc3..36cd743 100644 > --- a/drivers/platform/x86/fujitsu-laptop.c > +++ b/drivers/platform/x86/fujitsu-laptop.c > @@ -856,6 +856,7 @@ static int acpi_fujitsu_hotkey_add(struct acpi_device *device) > set_bit(fujitsu->keycode3, input->keybit); > set_bit(fujitsu->keycode4, input->keybit); > set_bit(fujitsu->keycode5, input->keybit); > + set_bit(KEY_TOUCHPAD_TOGGLE, input->keybit); > set_bit(KEY_UNKNOWN, input->keybit); > > error = input_register_device(input); > @@ -1060,6 +1061,19 @@ static void acpi_fujitsu_hotkey_notify(struct acpi_device *device, u32 event) > } > } > > + /* On some models (first seen on the Skylake-based Lifebook > + * E736/E746/E756), the touchpad toggle hotkey (Fn+F4) is > + * handled in software; its state is queried using FUNC_RFKILL > + */ > + if ((fujitsu_hotkey->rfkill_supported & BIT(26)) && > + (call_fext_func(FUNC_RFKILL, 0x1, 0x0, 0x0) & BIT(26))) { > + keycode = KEY_TOUCHPAD_TOGGLE; > + input_report_key(input, keycode, 1); > + input_sync(input); > + input_report_key(input, keycode, 0); > + input_sync(input); > + } > + > break; > default: > keycode = KEY_UNKNOWN; > -- > 1.7.10.4 -- ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models 2016-06-28 11:19 ` Jonathan Woithe @ 2016-06-28 17:50 ` Darren Hart 0 siblings, 0 replies; 9+ messages in thread From: Darren Hart @ 2016-06-28 17:50 UTC (permalink / raw) To: Jonathan Woithe Cc: Micha?? K??pie??, Jan-Marek Glogowski, platform-driver-x86, linux-kernel On Tue, Jun 28, 2016 at 08:49:22PM +0930, Jonathan Woithe wrote: > On Tue, Jun 28, 2016 at 09:25:50AM +0200, Micha?? K??pie?? wrote: > > Haswell-based Fujitsu laptops (Lifebook E734/E744/E754) have a touchpad > > toggle hotkey (Fn+F4) which is handled transparently to the operating > > system: while an ACPI notification is sent to FUJ02B1 when Fn+F4 is > > pressed, touchpad state is properly toggled without any explicit support > > for this operation in fujitsu-laptop. > > > > Skylake-based models (Lifebook E736/E746/E756) also have that hotkey, > > but the touchpad is not toggled transparently to the operating system. > > When Fn+F4 is pressed, an ACPI notification is sent to FUJ02E3. A > > subsequent call to S000 (FUNC_RFKILL) can be used to determine whether > > the touchpad toggle hotkey was pressed so that an input event can be > > sent to userspace. > > > > Relevant ACPI code: > > > > Method (_L21, 0, NotSerialized) > > { > > ... > > If (AHKF) > > { > > Notify (\_SB.FEXT, 0x80) > > } > > ... > > } > > > > Method (S000, 3, Serialized) > > { > > Name (_T_0, Zero) > > Local0 = Zero > > While (One) > > { > > _T_0 = Arg0 > > If (_T_0 == Zero) > > { > > Local0 |= 0x04000000 > > Local0 |= 0x02000000 > > Local0 |= 0x00020000 > > Local0 |= 0x0200 > > Local0 |= 0x0100 > > Local0 |= 0x20 > > } > > ElseIf (_T_0 == One) > > { > > ... > > If (AHKF & 0x08) > > { > > Local0 |= 0x04000000 > > AHKF ^= 0x08 > > } > > ... > > } ... > > Break > > } > > Return (Local0) > > } > > > > Pressing Fn+F4 raises GPE 0x21 and sets bit 3 in AHKF. This in turn > > results in bit 26 being set in the value returned by FUNC_RFKILL called > > with 1 as its first argument. On Skylake-based models, bit 26 is also > > set in the value returned by FUNC_RFKILL called with 0 as its first > > argument (this value is saved in fujitsu_hotkey->rfkill_supported upon > > module initialization), which suggests that this bit is set on models > > which do not handle touchpad toggling transparently to the operating > > system. > > > > Note that bit 3 is cleared in AHKF once FUNC_RFKILL is called with 1 as > > its first argument, which requires fujitsu-laptop to handle this hotkey > > in a different manner than the other, GIRB-based hotkeys: two input > > events (press and release) are immediately sent once Fn+F4 is pressed. > > > > Reported-and-tested-by: Jan-Marek Glogowski <glogow@fbihome.de> > > Signed-off-by: Micha?? K??pie?? <kernel@kempniu.pl> > > Thanks for the revision and your patience. > > Acked-by: Jonathan Woithe <jwoithe@just42.net> Queued to testing for 4.8, thanks. -- Darren Hart Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-06-28 17:50 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20160625091522.GA6423@eudyptula.hq.kempniu.pl> 2016-06-26 7:41 ` [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Michał Kępień 2016-06-27 8:03 ` [PATCH] Register KEY_TOUCHPAD_TOGGLE with input device Jan-Marek Glogowski 2016-06-27 12:48 ` [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Jonathan Woithe 2016-06-27 12:55 ` Michał Kępień 2016-06-27 13:19 ` [PATCH v2] " Michał Kępień 2016-06-28 1:06 ` Jonathan Woithe 2016-06-28 7:25 ` [PATCH v3] " Michał Kępień 2016-06-28 11:19 ` Jonathan Woithe 2016-06-28 17:50 ` Darren Hart
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).