* [PATCH V1] mfd: da9053: fix compiler warning message for uninitialised variable
@ 2016-06-27 15:06 Steve Twiss
2016-06-28 7:03 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Steve Twiss @ 2016-06-27 15:06 UTC (permalink / raw)
To: LINUXKERNEL, Lee Jones; +Cc: Geert Uytterhoeven, Support Opensource
From: Steve Twiss <stwiss.opensource@diasemi.com>
Fix compiler warning caused by an uninitialised variable inside
da9052_group_write() function. Defaulting the value to zero covers
the trivial case.
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Hi Lee,
This compiler warning was found and reported by Geert Uytterhoeven as
part of the "Build regressions/improvements in v4.7-rc5" thread.
- https://lkml.org/lkml/2016/6/27/126
Regards,
Steve
include/linux/mfd/da9052/da9052.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mfd/da9052/da9052.h b/include/linux/mfd/da9052/da9052.h
index c18a4c1..ce9230a 100644
--- a/include/linux/mfd/da9052/da9052.h
+++ b/include/linux/mfd/da9052/da9052.h
@@ -171,7 +171,7 @@ static inline int da9052_group_read(struct da9052 *da9052, unsigned char reg,
static inline int da9052_group_write(struct da9052 *da9052, unsigned char reg,
unsigned reg_cnt, unsigned char *val)
{
- int ret;
+ int ret = 0;
int i;
for (i = 0; i < reg_cnt; i++) {
--
end-of-patch for PATCH V1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V1] mfd: da9053: fix compiler warning message for uninitialised variable
2016-06-27 15:06 [PATCH V1] mfd: da9053: fix compiler warning message for uninitialised variable Steve Twiss
@ 2016-06-28 7:03 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2016-06-28 7:03 UTC (permalink / raw)
To: Steve Twiss; +Cc: LINUXKERNEL, Geert Uytterhoeven, Support Opensource
On Mon, 27 Jun 2016, Steve Twiss wrote:
> From: Steve Twiss <stwiss.opensource@diasemi.com>
>
> Fix compiler warning caused by an uninitialised variable inside
> da9052_group_write() function. Defaulting the value to zero covers
> the trivial case.
>
> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> ---
> Hi Lee,
>
> This compiler warning was found and reported by Geert Uytterhoeven as
> part of the "Build regressions/improvements in v4.7-rc5" thread.
>
> - https://lkml.org/lkml/2016/6/27/126
>
> Regards,
> Steve
>
>
> include/linux/mfd/da9052/da9052.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to -fixes.
> diff --git a/include/linux/mfd/da9052/da9052.h b/include/linux/mfd/da9052/da9052.h
> index c18a4c1..ce9230a 100644
> --- a/include/linux/mfd/da9052/da9052.h
> +++ b/include/linux/mfd/da9052/da9052.h
> @@ -171,7 +171,7 @@ static inline int da9052_group_read(struct da9052 *da9052, unsigned char reg,
> static inline int da9052_group_write(struct da9052 *da9052, unsigned char reg,
> unsigned reg_cnt, unsigned char *val)
> {
> - int ret;
> + int ret = 0;
> int i;
>
> for (i = 0; i < reg_cnt; i++) {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-28 7:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-27 15:06 [PATCH V1] mfd: da9053: fix compiler warning message for uninitialised variable Steve Twiss
2016-06-28 7:03 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).