* [PATCH v2 0/3] dt-bindings: RCar FCP and FDP1 bindings
@ 2016-06-30 16:50 Kieran Bingham
2016-06-30 16:50 ` [PATCH v2 1/3] dt-bindings: Update Renesas R-Car FCP DT binding Kieran Bingham
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Kieran Bingham @ 2016-06-30 16:50 UTC (permalink / raw)
To: laurent.pinchart, robh+dt, mark.rutland
Cc: linux-media, linux-renesas-soc, devicetree, linux-kernel, kieran
This updated series, has collected the Acked and Reviewed tags for the
FCPF binding addition, and adds documention of the optional power-domain
property for the FCP.
Finally the FDP1 bindings have been updated following review from Laurent.
Specifically, this removes the version specific compatibles as we have a
HW version register available to us in the hardware so we can detect at
run-time what device version we are running on.
Kieran Bingham (3):
dt-bindings: Update Renesas R-Car FCP DT binding
dt-bindings: Document Renesas R-Car FCP power-domains usage
dt-bindings: Add Renesas R-Car FDP1 bindings
.../devicetree/bindings/media/renesas,fcp.txt | 9 +++++-
.../devicetree/bindings/media/renesas,fdp1.txt | 33 ++++++++++++++++++++++
2 files changed, 41 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/3] dt-bindings: Update Renesas R-Car FCP DT binding
2016-06-30 16:50 [PATCH v2 0/3] dt-bindings: RCar FCP and FDP1 bindings Kieran Bingham
@ 2016-06-30 16:50 ` Kieran Bingham
2016-06-30 16:50 ` [PATCH v2 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Kieran Bingham
2016-06-30 16:50 ` [PATCH v2 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings Kieran Bingham
2 siblings, 0 replies; 7+ messages in thread
From: Kieran Bingham @ 2016-06-30 16:50 UTC (permalink / raw)
To: laurent.pinchart, robh+dt, mark.rutland
Cc: linux-media, linux-renesas-soc, devicetree, linux-kernel, kieran
The FCP driver can also support the FCPF variant for FDP1 compatible
processing.
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
index 6a12960609d8..271dcfdb5a76 100644
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
@@ -7,12 +7,14 @@ conversion of AXI transactions in order to reduce the memory bandwidth.
There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
for FDP (FCPF). Their configuration and behaviour depend on the module they
-are paired with. These DT bindings currently support the FCPV only.
+are paired with. These DT bindings currently support the FCPV and FCPF.
- compatible: Must be one or more of the following
- "renesas,r8a7795-fcpv" for R8A7795 (R-Car H3) compatible 'FCP for VSP'
+ - "renesas,r8a7795-fcpf" for R8A7795 (R-Car H3) compatible 'FCP for FDP'
- "renesas,fcpv" for generic compatible 'FCP for VSP'
+ - "renesas,fcpf" for generic compatible 'FCP for FDP'
When compatible with the generic version, nodes must list the
SoC-specific version corresponding to the platform first, followed by the
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage
2016-06-30 16:50 [PATCH v2 0/3] dt-bindings: RCar FCP and FDP1 bindings Kieran Bingham
2016-06-30 16:50 ` [PATCH v2 1/3] dt-bindings: Update Renesas R-Car FCP DT binding Kieran Bingham
@ 2016-06-30 16:50 ` Kieran Bingham
2016-07-01 2:49 ` Rob Herring
2016-07-17 16:31 ` Laurent Pinchart
2016-06-30 16:50 ` [PATCH v2 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings Kieran Bingham
2 siblings, 2 replies; 7+ messages in thread
From: Kieran Bingham @ 2016-06-30 16:50 UTC (permalink / raw)
To: laurent.pinchart, robh+dt, mark.rutland
Cc: linux-media, linux-renesas-soc, devicetree, linux-kernel, kieran
The power domain must be specified to bring the device out of module
standby. Document this in the bindings provided, so that new additions
are not missed.
Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
Documentation/devicetree/bindings/media/renesas,fcp.txt | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
index 271dcfdb5a76..5be21b6411ba 100644
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
@@ -23,6 +23,10 @@ are paired with. These DT bindings currently support the FCPV and FCPF.
- reg: the register base and size for the device registers
- clocks: Reference to the functional clock
+Optional properties:
+ - power-domains : power-domain property defined with a power domain specifier
+ to respective power domain.
+
Device node example
-------------------
@@ -31,4 +35,5 @@ Device node example
compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
reg = <0 0xfea2f000 0 0x200>;
clocks = <&cpg CPG_MOD 602>;
+ power-domains = <&sysc R8A7795_PD_A3VP>;
};
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings
2016-06-30 16:50 [PATCH v2 0/3] dt-bindings: RCar FCP and FDP1 bindings Kieran Bingham
2016-06-30 16:50 ` [PATCH v2 1/3] dt-bindings: Update Renesas R-Car FCP DT binding Kieran Bingham
2016-06-30 16:50 ` [PATCH v2 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Kieran Bingham
@ 2016-06-30 16:50 ` Kieran Bingham
2016-07-01 2:51 ` Rob Herring
2 siblings, 1 reply; 7+ messages in thread
From: Kieran Bingham @ 2016-06-30 16:50 UTC (permalink / raw)
To: laurent.pinchart, robh+dt, mark.rutland
Cc: linux-media, linux-renesas-soc, devicetree, linux-kernel, kieran
The FDP1 is a de-interlacing module which converts interlaced video to
progressive video. It is also capable of performing pixel format conversion
between YCbCr/YUV formats and RGB formats.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
Changes since v1:
- title fixed
- Interrupts property documented
- version specific compatibles removed as we have a hw version register
- label removed from device node example
* (fdp1 is not referenced by other nodes)
.../devicetree/bindings/media/renesas,fdp1.txt | 33 ++++++++++++++++++++++
1 file changed, 33 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
new file mode 100644
index 000000000000..e6abd2a17e66
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
@@ -0,0 +1,33 @@
+Renesas R-Car Fine Display Processor (FDP1)
+-------------------------------------------
+
+The FDP1 is a de-interlacing module which converts interlaced video to
+progressive video. It is capable of performing pixel format conversion between
+YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
+an input to the module.
+
+ - compatible: Must be the following
+
+ - "renesas,fdp1" for generic compatible
+
+ - reg: the register base and size for the device registers
+ - interrupts : interrupt specifier for the FDP1 instance
+ - clocks: reference to the functional clock
+ - renesas,fcp: reference to the FCPF connected to the FDP1
+
+Optional properties:
+ - power-domains : power-domain property defined with a power domain specifier
+ to respective power domain.
+
+
+Device node example
+-------------------
+
+ fdp1@fe940000 {
+ compatible = "renesas,fdp1";
+ reg = <0 0xfe940000 0 0x2400>;
+ interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 119>;
+ power-domains = <&sysc R8A7795_PD_A3VP>;
+ renesas,fcp = <&fcpf0>;
+ };
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage
2016-06-30 16:50 ` [PATCH v2 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Kieran Bingham
@ 2016-07-01 2:49 ` Rob Herring
2016-07-17 16:31 ` Laurent Pinchart
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2016-07-01 2:49 UTC (permalink / raw)
To: Kieran Bingham
Cc: laurent.pinchart, mark.rutland, linux-media, linux-renesas-soc,
devicetree, linux-kernel
On Thu, Jun 30, 2016 at 05:50:29PM +0100, Kieran Bingham wrote:
> The power domain must be specified to bring the device out of module
> standby. Document this in the bindings provided, so that new additions
> are not missed.
>
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
> Documentation/devicetree/bindings/media/renesas,fcp.txt | 5 +++++
> 1 file changed, 5 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings
2016-06-30 16:50 ` [PATCH v2 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings Kieran Bingham
@ 2016-07-01 2:51 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2016-07-01 2:51 UTC (permalink / raw)
To: Kieran Bingham
Cc: laurent.pinchart, mark.rutland, linux-media, linux-renesas-soc,
devicetree, linux-kernel
On Thu, Jun 30, 2016 at 05:50:30PM +0100, Kieran Bingham wrote:
> The FDP1 is a de-interlacing module which converts interlaced video to
> progressive video. It is also capable of performing pixel format conversion
> between YCbCr/YUV formats and RGB formats.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
> Changes since v1:
> - title fixed
> - Interrupts property documented
> - version specific compatibles removed as we have a hw version register
> - label removed from device node example
> * (fdp1 is not referenced by other nodes)
>
> .../devicetree/bindings/media/renesas,fdp1.txt | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage
2016-06-30 16:50 ` [PATCH v2 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Kieran Bingham
2016-07-01 2:49 ` Rob Herring
@ 2016-07-17 16:31 ` Laurent Pinchart
1 sibling, 0 replies; 7+ messages in thread
From: Laurent Pinchart @ 2016-07-17 16:31 UTC (permalink / raw)
To: Kieran Bingham
Cc: robh+dt, mark.rutland, linux-media, linux-renesas-soc,
devicetree, linux-kernel
Hi Kieran,
Thank you for the patch.
On Thursday 30 Jun 2016 17:50:29 Kieran Bingham wrote:
> The power domain must be specified to bring the device out of module
> standby. Document this in the bindings provided, so that new additions
> are not missed.
>
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/media/renesas,fcp.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> b/Documentation/devicetree/bindings/media/renesas,fcp.txt index
> 271dcfdb5a76..5be21b6411ba 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> @@ -23,6 +23,10 @@ are paired with. These DT bindings currently support the
> FCPV and FCPF. - reg: the register base and size for the device registers
> - clocks: Reference to the functional clock
>
> +Optional properties:
> + - power-domains : power-domain property defined with a power domain
> specifier
> + to respective power domain.
> +
>
> Device node example
> -------------------
> @@ -31,4 +35,5 @@ Device node example
> compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
> reg = <0 0xfea2f000 0 0x200>;
> clocks = <&cpg CPG_MOD 602>;
> + power-domains = <&sysc R8A7795_PD_A3VP>;
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-07-17 16:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-30 16:50 [PATCH v2 0/3] dt-bindings: RCar FCP and FDP1 bindings Kieran Bingham
2016-06-30 16:50 ` [PATCH v2 1/3] dt-bindings: Update Renesas R-Car FCP DT binding Kieran Bingham
2016-06-30 16:50 ` [PATCH v2 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Kieran Bingham
2016-07-01 2:49 ` Rob Herring
2016-07-17 16:31 ` Laurent Pinchart
2016-06-30 16:50 ` [PATCH v2 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings Kieran Bingham
2016-07-01 2:51 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).