* [PATCH] ALSA: ppc/awacs: shut up maybe-uninitialized warning
@ 2016-07-04 15:07 Arnd Bergmann
2016-07-05 6:37 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-07-04 15:07 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Arnd Bergmann, alsa-devel, linux-kernel
The awacs sound driver produces a false-positive warning in ppc64_defconfig:
sound/ppc/awacs.c: In function 'snd_pmac_awacs_init':
include/sound/control.h:219:9: warning: 'master_vol' may be used uninitialized in this function [-Wmaybe-uninitialized]
I haven't come up with a good way to rewrite the code to avoid the
warning, so here is a bad one: I initialize the variable before
the conditionall initialization so gcc no longer has to worry about
it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/ppc/awacs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/ppc/awacs.c b/sound/ppc/awacs.c
index 09da7b52bc2e..1468e4b7bf93 100644
--- a/sound/ppc/awacs.c
+++ b/sound/ppc/awacs.c
@@ -991,6 +991,7 @@ snd_pmac_awacs_init(struct snd_pmac *chip)
if (err < 0)
return err;
}
+ master_vol = NULL;
if (pm7500)
err = build_mixers(chip,
ARRAY_SIZE(snd_pmac_awacs_mixers_pmac7500),
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: ppc/awacs: shut up maybe-uninitialized warning
2016-07-04 15:07 [PATCH] ALSA: ppc/awacs: shut up maybe-uninitialized warning Arnd Bergmann
@ 2016-07-05 6:37 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2016-07-05 6:37 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Jaroslav Kysela, alsa-devel, linux-kernel
On Mon, 04 Jul 2016 17:07:45 +0200,
Arnd Bergmann wrote:
>
> The awacs sound driver produces a false-positive warning in ppc64_defconfig:
>
> sound/ppc/awacs.c: In function 'snd_pmac_awacs_init':
> include/sound/control.h:219:9: warning: 'master_vol' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> I haven't come up with a good way to rewrite the code to avoid the
> warning, so here is a bad one: I initialize the variable before
> the conditionall initialization so gcc no longer has to worry about
> it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-05 6:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-04 15:07 [PATCH] ALSA: ppc/awacs: shut up maybe-uninitialized warning Arnd Bergmann
2016-07-05 6:37 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).