linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] batman-adv: fix boolreturn.cocci warnings
  2016-07-06  2:49 net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool kbuild test robot
@ 2016-07-06  2:49 ` kbuild test robot
  2016-07-06 13:44   ` [B.A.T.M.A.N.] " Marek Lindner
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2016-07-06  2:49 UTC (permalink / raw)
  Cc: kbuild-all, linux-kernel, Antonio Quartulli, Sven Eckelmann,
	Marek Lindner, Simon Wunderlich, b.a.t.m.a.n, netdev

net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 bridge_loop_avoidance.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/batman-adv/bridge_loop_avoidance.c
+++ b/net/batman-adv/bridge_loop_avoidance.c
@@ -1102,7 +1102,7 @@ static bool batadv_bla_process_claim(str
 
 	/* Let the loopdetect frames on the mesh in any case. */
 	if (bla_dst->type == BATADV_CLAIM_TYPE_LOOPDETECT)
-		return 0;
+		return false;
 
 	/* check if it is a claim frame. */
 	ret = batadv_check_claim_group(bat_priv, primary_if, hw_src, hw_dst,

^ permalink raw reply	[flat|nested] 3+ messages in thread

* net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool
@ 2016-07-06  2:49 kbuild test robot
  2016-07-06  2:49 ` [PATCH] batman-adv: fix boolreturn.cocci warnings kbuild test robot
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2016-07-06  2:49 UTC (permalink / raw)
  Cc: kbuild-all, linux-kernel, Antonio Quartulli, Sven Eckelmann,
	Marek Lindner

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a99cde438de0c4c0cecc1d1af1a55a75b10bfdef
commit: 4b426b108ac82b27f5af40df7da05a2501fd2aca batman-adv: Use bool as return type for boolean functions
date:   8 weeks ago


coccinelle warnings: (new ones prefixed by >>)

>> net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings
  2016-07-06  2:49 ` [PATCH] batman-adv: fix boolreturn.cocci warnings kbuild test robot
@ 2016-07-06 13:44   ` Marek Lindner
  0 siblings, 0 replies; 3+ messages in thread
From: Marek Lindner @ 2016-07-06 13:44 UTC (permalink / raw)
  To: b.a.t.m.a.n
  Cc: kbuild test robot, netdev, Antonio Quartulli, linux-kernel,
	kbuild-all, Sven Eckelmann

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

On Wednesday, July 06, 2016 10:49:29 kbuild test robot wrote:
> net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in
> function 'batadv_bla_process_claim' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> CC: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  bridge_loop_avoidance.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied in revision 36e7316.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-07-06 14:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-06  2:49 net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool kbuild test robot
2016-07-06  2:49 ` [PATCH] batman-adv: fix boolreturn.cocci warnings kbuild test robot
2016-07-06 13:44   ` [B.A.T.M.A.N.] " Marek Lindner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).