* [PATCH 1/2] exit: Quieten greatest stack depth printk
@ 2016-06-26 23:01 Anton Blanchard
2016-06-26 23:01 ` [PATCH 2/2] mm: workingset: printk missing log level, use pr_info() Anton Blanchard
0 siblings, 1 reply; 4+ messages in thread
From: Anton Blanchard @ 2016-06-26 23:01 UTC (permalink / raw)
To: akpm, oleg, hannes, mingo, fweisbec, jkosina; +Cc: linux-kernel
From: Anton Blanchard <anton@samba.org>
Many targets enable CONFIG_DEBUG_STACK_USAGE, and while the information
is useful, it isn't worthy of pr_warn(). Reduce it to pr_info().
Signed-off-by: Anton Blanchard <anton@samba.org>
---
kernel/exit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/exit.c b/kernel/exit.c
index 9e6e135..bbdef62 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -639,7 +639,7 @@ static void check_stack_usage(void)
spin_lock(&low_water_lock);
if (free < lowest_to_date) {
- pr_warn("%s (%d) used greatest stack depth: %lu bytes left\n",
+ pr_info("%s (%d) used greatest stack depth: %lu bytes left\n",
current->comm, task_pid_nr(current), free);
lowest_to_date = free;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] mm: workingset: printk missing log level, use pr_info()
2016-06-26 23:01 [PATCH 1/2] exit: Quieten greatest stack depth printk Anton Blanchard
@ 2016-06-26 23:01 ` Anton Blanchard
2016-06-27 4:01 ` Joe Perches
2016-07-06 13:57 ` Johannes Weiner
0 siblings, 2 replies; 4+ messages in thread
From: Anton Blanchard @ 2016-06-26 23:01 UTC (permalink / raw)
To: akpm, oleg, hannes, mingo, fweisbec, jkosina; +Cc: linux-kernel
From: Anton Blanchard <anton@samba.org>
commit 612e44939c3c ("mm: workingset: eviction buckets for bigmem/lowbit
machines") added a printk without a log level. Quieten it by using
pr_info().
Signed-off-by: Anton Blanchard <anton@samba.org>
---
mm/workingset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/workingset.c b/mm/workingset.c
index 8a75f8d..5772775 100644
--- a/mm/workingset.c
+++ b/mm/workingset.c
@@ -491,7 +491,7 @@ static int __init workingset_init(void)
max_order = fls_long(totalram_pages - 1);
if (max_order > timestamp_bits)
bucket_order = max_order - timestamp_bits;
- printk("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
+ pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
timestamp_bits, max_order, bucket_order);
ret = list_lru_init_key(&workingset_shadow_nodes, &shadow_nodes_key);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] mm: workingset: printk missing log level, use pr_info()
2016-06-26 23:01 ` [PATCH 2/2] mm: workingset: printk missing log level, use pr_info() Anton Blanchard
@ 2016-06-27 4:01 ` Joe Perches
2016-07-06 13:57 ` Johannes Weiner
1 sibling, 0 replies; 4+ messages in thread
From: Joe Perches @ 2016-06-27 4:01 UTC (permalink / raw)
To: Anton Blanchard, akpm, oleg, hannes, mingo, fweisbec, jkosina
Cc: linux-kernel
On Mon, 2016-06-27 at 09:01 +1000, Anton Blanchard wrote:
> commit 612e44939c3c ("mm: workingset: eviction buckets for bigmem/lowbit
> machines") added a printk without a log level. Quieten it by using
> pr_info().
[]
> diff --git a/mm/workingset.c b/mm/workingset.c
[]
> @@ -491,7 +491,7 @@ static int __init workingset_init(void)
> max_order = fls_long(totalram_pages - 1);
> if (max_order > timestamp_bits)
> bucket_order = max_order - timestamp_bits;
> - printk("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
> + pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
> timestamp_bits, max_order, bucket_order);
Because it's possible to have more printks added,
perhaps it's better to add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any #include and remove the "workingset: "
prefix here.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] mm: workingset: printk missing log level, use pr_info()
2016-06-26 23:01 ` [PATCH 2/2] mm: workingset: printk missing log level, use pr_info() Anton Blanchard
2016-06-27 4:01 ` Joe Perches
@ 2016-07-06 13:57 ` Johannes Weiner
1 sibling, 0 replies; 4+ messages in thread
From: Johannes Weiner @ 2016-07-06 13:57 UTC (permalink / raw)
To: Anton Blanchard; +Cc: akpm, oleg, mingo, fweisbec, jkosina, linux-kernel
On Mon, Jun 27, 2016 at 09:01:12AM +1000, Anton Blanchard wrote:
> From: Anton Blanchard <anton@samba.org>
>
> commit 612e44939c3c ("mm: workingset: eviction buckets for bigmem/lowbit
> machines") added a printk without a log level. Quieten it by using
> pr_info().
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-06 13:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-26 23:01 [PATCH 1/2] exit: Quieten greatest stack depth printk Anton Blanchard
2016-06-26 23:01 ` [PATCH 2/2] mm: workingset: printk missing log level, use pr_info() Anton Blanchard
2016-06-27 4:01 ` Joe Perches
2016-07-06 13:57 ` Johannes Weiner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).