From: Ingo Molnar <mingo@kernel.org>
To: Brian Gerst <brgerst@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>, Borislav Petkov <bp@suse.de>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame
Date: Sat, 9 Jul 2016 14:01:27 +0200 [thread overview]
Message-ID: <20160709120127.GA26253@gmail.com> (raw)
In-Reply-To: <CAMzpN2iou897i1f621Oh442ZoUY7A4=3FOhCP-qnT5U5BMEd5A@mail.gmail.com>
* Brian Gerst <brgerst@gmail.com> wrote:
> On Mon, Jun 20, 2016 at 11:14 AM, Borislav Petkov <bp@alien8.de> wrote:
> > On Mon, Jun 20, 2016 at 11:01:02AM -0400, Brian Gerst wrote:
> >> The idea was to put the uncommon case (kernel thread) out of line for
> >> performance reasons.
> >
> > A comment saying so wouldn't hurt...
>
> This is a fairly common pattern. Do we have to document every case of it?
Yeah, would be good to do that in general, so that people can re-evaluate whether
'this is rare' is still true years down the line. For newly touched code it makes
sense to add a minimal comment that explains what is rare about the branch and so.
Thanks,
Ingo
next prev parent reply other threads:[~2016-07-09 12:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 20:56 [PATCH v2 0/6] x86: Rewrite switch_to() Brian Gerst
2016-06-18 20:56 ` [PATCH v2 1/6] x86-32, kgdb: Don't use thread.ip in sleeping_thread_to_gdb_regs() Brian Gerst
2016-06-18 20:56 ` [PATCH v2 2/6] x86-64, kgdb: clear GDB_PS on 64-bit Brian Gerst
2016-06-18 20:56 ` [PATCH v2 3/6] x86: Add struct inactive_task_frame Brian Gerst
2016-06-19 21:18 ` Andy Lutomirski
2016-06-20 15:39 ` Josh Poimboeuf
2016-06-18 20:56 ` [PATCH v2 4/6] x86: Rewrite switch_to() code Brian Gerst
2016-06-19 21:22 ` Andy Lutomirski
2016-06-20 15:44 ` Josh Poimboeuf
2016-06-18 20:56 ` [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame Brian Gerst
2016-06-19 21:28 ` Andy Lutomirski
2016-06-19 22:01 ` Brian Gerst
2016-06-20 13:51 ` Borislav Petkov
2016-06-20 15:01 ` Brian Gerst
2016-06-20 15:14 ` Borislav Petkov
2016-06-22 4:24 ` Brian Gerst
2016-07-09 12:01 ` Ingo Molnar [this message]
2016-06-18 20:56 ` [PATCH v2 6/6] x86: Fix thread_saved_pc() Brian Gerst
2016-06-20 16:01 ` Josh Poimboeuf
2016-06-22 4:27 ` Brian Gerst
2016-06-24 18:12 ` Josh Poimboeuf
2016-06-19 22:05 ` [PATCH v2 0/6] x86: Rewrite switch_to() Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160709120127.GA26253@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).