* [PATCH] ACPI / lpat: make it explicitly non-modular
@ 2016-07-11 21:22 Paul Gortmaker
2016-07-19 20:09 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2016-07-11 21:22 UTC (permalink / raw)
To: linux-kernel; +Cc: Paul Gortmaker, Rafael J. Wysocki, Len Brown, linux-acpi
The Makefile for building this is "acpi-y" and so it is not built
as a module. Hence including module.h and everything that comes
with it just for the no-op MODULE_LICENSE is rather heavy handed.
The license info is found at the top of the file, so we just remove
the MODULE_LICENSE and the include of module.h
We add an include of export.h since the file exports some symbols.
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/acpi/acpi_lpat.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/acpi/acpi_lpat.c b/drivers/acpi/acpi_lpat.c
index feb61c1630eb..c1c4877ca96c 100644
--- a/drivers/acpi/acpi_lpat.c
+++ b/drivers/acpi/acpi_lpat.c
@@ -13,7 +13,7 @@
* GNU General Public License for more details.
*/
-#include <linux/module.h>
+#include <linux/export.h>
#include <linux/acpi.h>
#include <acpi/acpi_lpat.h>
@@ -157,5 +157,3 @@ void acpi_lpat_free_conversion_table(struct acpi_lpat_conversion_table
}
}
EXPORT_SYMBOL_GPL(acpi_lpat_free_conversion_table);
-
-MODULE_LICENSE("GPL");
--
2.8.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI / lpat: make it explicitly non-modular
2016-07-11 21:22 [PATCH] ACPI / lpat: make it explicitly non-modular Paul Gortmaker
@ 2016-07-19 20:09 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2016-07-19 20:09 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linux-kernel, Len Brown, linux-acpi
On Monday, July 11, 2016 05:22:41 PM Paul Gortmaker wrote:
> The Makefile for building this is "acpi-y" and so it is not built
> as a module. Hence including module.h and everything that comes
> with it just for the no-op MODULE_LICENSE is rather heavy handed.
>
> The license info is found at the top of the file, so we just remove
> the MODULE_LICENSE and the include of module.h
>
> We add an include of export.h since the file exports some symbols.
>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> Cc: linux-acpi@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-19 20:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-11 21:22 [PATCH] ACPI / lpat: make it explicitly non-modular Paul Gortmaker
2016-07-19 20:09 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).