From: Arnd Bergmann <arnd@arndb.de>
To: Jiri Kosina <jikos@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Yusuke Fujimaki <usk.fujimaki@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY
Date: Mon, 11 Jul 2016 23:49:20 +0200 [thread overview]
Message-ID: <20160711214954.2668262-1-arnd@arndb.de> (raw)
A recent commit added barry support to this driver, but that causes
a link failure when CONFIG_POWER_SUPPLY is not set:
drivers/hid/built-in.o: In function `hidpp_battery_get_property':
:(.text+0x1a834): undefined reference to `power_supply_get_drvdata'
drivers/hid/built-in.o: In function `hidpp_raw_event':
:(.text+0x1b10c): undefined reference to `power_supply_changed'
drivers/hid/built-in.o: In function `hidpp_connect_event':
:(.text+0x1bd88): undefined reference to `devm_power_supply_register'
:(.text+0x1be30): undefined reference to `power_supply_powers'
This adds a dependency, identically to the other HID drivers that need this.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices")
---
drivers/hid/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 78ac4811bd3c..4c6b59c9fa15 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -440,6 +440,7 @@ config HID_LOGITECH_DJ
config HID_LOGITECH_HIDPP
tristate "Logitech HID++ devices support"
depends on HID_LOGITECH
+ select POWER_SUPPLY
---help---
Support for Logitech devices relyingon the HID++ Logitech specification
--
2.9.0
next reply other threads:[~2016-07-11 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 21:49 Arnd Bergmann [this message]
2016-07-12 7:19 ` [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY Benjamin Tissoires
2016-07-12 9:18 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711214954.2668262-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=benjamin.tissoires@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=usk.fujimaki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).