* [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY
@ 2016-07-11 21:49 Arnd Bergmann
2016-07-12 7:19 ` Benjamin Tissoires
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2016-07-11 21:49 UTC (permalink / raw)
To: Jiri Kosina
Cc: Arnd Bergmann, Benjamin Tissoires, Heiner Kallweit,
Yusuke Fujimaki, linux-input, linux-kernel
A recent commit added barry support to this driver, but that causes
a link failure when CONFIG_POWER_SUPPLY is not set:
drivers/hid/built-in.o: In function `hidpp_battery_get_property':
:(.text+0x1a834): undefined reference to `power_supply_get_drvdata'
drivers/hid/built-in.o: In function `hidpp_raw_event':
:(.text+0x1b10c): undefined reference to `power_supply_changed'
drivers/hid/built-in.o: In function `hidpp_connect_event':
:(.text+0x1bd88): undefined reference to `devm_power_supply_register'
:(.text+0x1be30): undefined reference to `power_supply_powers'
This adds a dependency, identically to the other HID drivers that need this.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices")
---
drivers/hid/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 78ac4811bd3c..4c6b59c9fa15 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -440,6 +440,7 @@ config HID_LOGITECH_DJ
config HID_LOGITECH_HIDPP
tristate "Logitech HID++ devices support"
depends on HID_LOGITECH
+ select POWER_SUPPLY
---help---
Support for Logitech devices relyingon the HID++ Logitech specification
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY
2016-07-11 21:49 [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY Arnd Bergmann
@ 2016-07-12 7:19 ` Benjamin Tissoires
2016-07-12 9:18 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Tissoires @ 2016-07-12 7:19 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jiri Kosina, Heiner Kallweit, Yusuke Fujimaki, linux-input, linux-kernel
On Jul 11 2016 or thereabouts, Arnd Bergmann wrote:
> A recent commit added barry support to this driver, but that causes
> a link failure when CONFIG_POWER_SUPPLY is not set:
>
> drivers/hid/built-in.o: In function `hidpp_battery_get_property':
> :(.text+0x1a834): undefined reference to `power_supply_get_drvdata'
> drivers/hid/built-in.o: In function `hidpp_raw_event':
> :(.text+0x1b10c): undefined reference to `power_supply_changed'
> drivers/hid/built-in.o: In function `hidpp_connect_event':
> :(.text+0x1bd88): undefined reference to `devm_power_supply_register'
> :(.text+0x1be30): undefined reference to `power_supply_powers'
>
> This adds a dependency, identically to the other HID drivers that need this.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices")
Thanks for the fix.
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> ---
> drivers/hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 78ac4811bd3c..4c6b59c9fa15 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -440,6 +440,7 @@ config HID_LOGITECH_DJ
> config HID_LOGITECH_HIDPP
> tristate "Logitech HID++ devices support"
> depends on HID_LOGITECH
> + select POWER_SUPPLY
> ---help---
> Support for Logitech devices relyingon the HID++ Logitech specification
>
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY
2016-07-12 7:19 ` Benjamin Tissoires
@ 2016-07-12 9:18 ` Jiri Kosina
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2016-07-12 9:18 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: Arnd Bergmann, Heiner Kallweit, Yusuke Fujimaki, linux-input,
linux-kernel
On Tue, 12 Jul 2016, Benjamin Tissoires wrote:
> > A recent commit added barry support to this driver, but that causes
> > a link failure when CONFIG_POWER_SUPPLY is not set:
> >
> > drivers/hid/built-in.o: In function `hidpp_battery_get_property':
> > :(.text+0x1a834): undefined reference to `power_supply_get_drvdata'
> > drivers/hid/built-in.o: In function `hidpp_raw_event':
> > :(.text+0x1b10c): undefined reference to `power_supply_changed'
> > drivers/hid/built-in.o: In function `hidpp_connect_event':
> > :(.text+0x1bd88): undefined reference to `devm_power_supply_register'
> > :(.text+0x1be30): undefined reference to `power_supply_powers'
> >
> > This adds a dependency, identically to the other HID drivers that need this.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices")
>
> Thanks for the fix.
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Thanks. I am pushing this to for-4.8/logitech-hidpp-battery, but I will be
unmerging that branch from 'for-next' shortly anyway, as the whole
patchset is currently on hold.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-12 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-11 21:49 [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY Arnd Bergmann
2016-07-12 7:19 ` Benjamin Tissoires
2016-07-12 9:18 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).