[PATCH] ACPI / PCI: make pci_slot explicitly non-modular

[PATCH] ACPI / PCI: make pci_slot explicitly non-modular

[Paul Gortmaker]

The Kconfig for this file is:

drivers/acpi/Kconfig:config ACPI_PCI_SLOT
drivers/acpi/Kconfig:   bool "PCI slot detection driver"

...and so it is not built as a module.  Hence including module.h
and everything that comes with it just for the no-op MODULE_LICENSE
and friends is rather heavy handed.

The license/author info is found at the top of the file, so we
just remove the MODULE_LICENSE etc and the include of module.h

We delete the DRIVER_VERSION macro as well since it is unused.

Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/acpi/pci_slot.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/acpi/pci_slot.c b/drivers/acpi/pci_slot.c
index 1236fb04a708..f62c68e24317 100644
--- a/drivers/acpi/pci_slot.c
+++ b/drivers/acpi/pci_slot.c
@@ -25,7 +25,6 @@
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
 #include <linux/kernel.h>
-#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
 #include <linux/types.h>
@@ -37,13 +36,6 @@
 
 static int check_sta_before_sun;
 
-#define DRIVER_VERSION 	"0.1"
-#define DRIVER_AUTHOR	"Alex Chiang <achiang@hp.com>"
-#define DRIVER_DESC	"ACPI PCI Slot Detection Driver"
-MODULE_AUTHOR(DRIVER_AUTHOR);
-MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_LICENSE("GPL");
-
 #define _COMPONENT		ACPI_PCI_COMPONENT
 ACPI_MODULE_NAME("pci_slot");
 
-- 
2.8.4

Re: [PATCH] ACPI / PCI: make pci_slot explicitly non-modular

[Rafael J. Wysocki]

On Monday, July 11, 2016 06:17:23 PM Paul Gortmaker wrote:
> The Kconfig for this file is:
> 
> drivers/acpi/Kconfig:config ACPI_PCI_SLOT
> drivers/acpi/Kconfig:   bool "PCI slot detection driver"
> 
> ...and so it is not built as a module.  Hence including module.h
> and everything that comes with it just for the no-op MODULE_LICENSE
> and friends is rather heavy handed.
> 
> The license/author info is found at the top of the file, so we
> just remove the MODULE_LICENSE etc and the include of module.h
> 
> We delete the DRIVER_VERSION macro as well since it is unused.
> 
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> Cc: linux-acpi@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Applied, thanks!