* [PATCH] mtd: spi-nor: support dual, quad, and WP for Gigadevice
@ 2016-07-01 22:25 Brian Norris
2016-07-14 0:36 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Brian Norris @ 2016-07-01 22:25 UTC (permalink / raw)
To: linux-mtd
Cc: linux-kernel, Brian Norris, Marek Vasut, Rafał Miłecki,
Ezequiel Garcia
Gigadevice flash support BP{0,1,2,3,4} bits, where BP3 means the same as
the existing supported TB (Top/Bottom), and BP4 means the same as the
not-yet-supported 4K bit used on other flash (e.g., Winbond). Let's
support lock/unlock with the same feature flags as w25q32dw/w25q64dw.
Tested on gd25lq64c, but I checked datasheets for the other 3, to make
sure.
While I was at it, I noticed that these all support dual and quad as
well. I noted them, but can't test them at the moment, since my test
system only supports standard 1x SPI.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
drivers/mtd/spi-nor/spi-nor.c | 24 ++++++++++++++++++++----
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 9551e41699c8..aa4d76fff70b 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -870,10 +870,26 @@ static const struct flash_info spi_nor_ids[] = {
{ "mb85rs1mt", INFO(0x047f27, 0, 128 * 1024, 1, SPI_NOR_NO_ERASE) },
/* GigaDevice */
- { "gd25q32", INFO(0xc84016, 0, 64 * 1024, 64, SECT_4K) },
- { "gd25q64", INFO(0xc84017, 0, 64 * 1024, 128, SECT_4K) },
- { "gd25lq64c", INFO(0xc86017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
- { "gd25q128", INFO(0xc84018, 0, 64 * 1024, 256, SECT_4K) },
+ {
+ "gd25q32", INFO(0xc84016, 0, 64 * 1024, 64,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+ },
+ {
+ "gd25q64", INFO(0xc84017, 0, 64 * 1024, 128,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+ },
+ {
+ "gd25lq64c", INFO(0xc86017, 0, 64 * 1024, 128,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+ },
+ {
+ "gd25q128", INFO(0xc84018, 0, 64 * 1024, 256,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+ },
/* Intel/Numonyx -- xxxs33b */
{ "160s33b", INFO(0x898911, 0, 64 * 1024, 32, 0) },
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: spi-nor: support dual, quad, and WP for Gigadevice
2016-07-01 22:25 [PATCH] mtd: spi-nor: support dual, quad, and WP for Gigadevice Brian Norris
@ 2016-07-14 0:36 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2016-07-14 0:36 UTC (permalink / raw)
To: linux-mtd
Cc: linux-kernel, Marek Vasut, Rafał Miłecki, Ezequiel Garcia
On Fri, Jul 01, 2016 at 03:25:16PM -0700, Brian Norris wrote:
> Gigadevice flash support BP{0,1,2,3,4} bits, where BP3 means the same as
> the existing supported TB (Top/Bottom), and BP4 means the same as the
> not-yet-supported 4K bit used on other flash (e.g., Winbond). Let's
> support lock/unlock with the same feature flags as w25q32dw/w25q64dw.
>
> Tested on gd25lq64c, but I checked datasheets for the other 3, to make
> sure.
>
> While I was at it, I noticed that these all support dual and quad as
> well. I noted them, but can't test them at the moment, since my test
> system only supports standard 1x SPI.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Applied to l2-mtd.git
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-14 0:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-01 22:25 [PATCH] mtd: spi-nor: support dual, quad, and WP for Gigadevice Brian Norris
2016-07-14 0:36 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).