From: Mark Brown <broonie@kernel.org>
To: Steve Twiss <stwiss.opensource@diasemi.com>
Cc: DEVICETREE <devicetree@vger.kernel.org>,
LINUXKERNEL <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH V1] regulator: da9210: addition of device tree support
Date: Thu, 14 Jul 2016 16:48:21 +0100 [thread overview]
Message-ID: <20160714154821.GA30372@sirena.org.uk> (raw)
In-Reply-To: <20160713154433.496843FAD9@swsrvapps-01.diasemi.com>
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
On Wed, Jul 13, 2016 at 04:41:19PM +0100, Steve Twiss wrote:
> Two files are modified, the driver source file and the binding document.
> Updates for the regulator source file include an .of_match_table entry, node
> match checking in the probe() function for a compatible da9210 string, and
> a new "BUCK" regulator entry. The binding documentation changes have been
> made to reflect these updates.
If the device only has one regulator and no other functionality I'd
expect the properties to just be in the top level node for the device -
no need to go fiddling around with a subnode to hold another subnode to
hold all the properties.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-07-14 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 15:41 [PATCH V1] regulator: da9210: addition of device tree support Steve Twiss
2016-07-14 15:48 ` Mark Brown [this message]
2016-07-15 9:17 ` Steve Twiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714154821.GA30372@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).