From: Steve Twiss <stwiss.opensource@diasemi.com>
To: Mark Brown <broonie@kernel.org>
Cc: DEVICETREE <devicetree@vger.kernel.org>,
LINUXKERNEL <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
"Support Opensource" <Support.Opensource@diasemi.com>
Subject: RE: [PATCH V1] regulator: da9210: addition of device tree support
Date: Fri, 15 Jul 2016 09:17:39 +0000 [thread overview]
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB70173DAB217@SW-EX-MBX02.diasemi.com> (raw)
In-Reply-To: <20160714154821.GA30372@sirena.org.uk>
On 14 July 2016 16:48, Mark Brown wrote:
> To: Steve Twiss
> Cc: DEVICETREE; LINUXKERNEL; Liam Girdwood; Mark Rutland; Rob Herring;
> Support Opensource
> Subject: Re: [PATCH V1] regulator: da9210: addition of device tree support
>
> On Wed, Jul 13, 2016 at 04:41:19PM +0100, Steve Twiss wrote:
>
> > Two files are modified, the driver source file and the binding document.
> > Updates for the regulator source file include an .of_match_table entry, node
> > match checking in the probe() function for a compatible da9210 string, and
> > a new "BUCK" regulator entry. The binding documentation changes have been
> > made to reflect these updates.
>
> If the device only has one regulator and no other functionality I'd
> expect the properties to just be in the top level node for the device -
> no need to go fiddling around with a subnode to hold another subnode to
> hold all the properties.
Agreed.
I will revert those changes to the device tree and re-submit V2.
prev parent reply other threads:[~2016-07-15 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 15:41 [PATCH V1] regulator: da9210: addition of device tree support Steve Twiss
2016-07-14 15:48 ` Mark Brown
2016-07-15 9:17 ` Steve Twiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ED8E3B22081A4459DAC7699F3695FB70173DAB217@SW-EX-MBX02.diasemi.com \
--to=stwiss.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).