From: Andrey Pronin <apronin@chromium.org>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
groeck@chromium.org, smbarber@chromium.org,
dianders@chromium.org
Subject: Re: [PATCH 2/2] tpm: support driver-specific sysfs attrs in tpm_tis_core
Date: Thu, 14 Jul 2016 20:35:30 -0700 [thread overview]
Message-ID: <20160715033530.GB27104@apronin> (raw)
In-Reply-To: <20160715032327.GF9347@obsidianresearch.com>
On Thu, Jul 14, 2016 at 09:23:27PM -0600, Jason Gunthorpe wrote:
> On Thu, Jul 14, 2016 at 06:51:36PM -0700, Andrey Pronin wrote:
> > - WARN_ON(chip->groups_cnt != 0);
>
> Nope.
>
> > - const struct attribute_group *groups[3];
> > + /* up to 4 attribute groups:
> > + * - driver-specific
> > + * - common TPM1.2 and TPM2.0
> > + * - TPM1.2/2.0-specific
> > + * - ppi
> > + */
> > + const struct attribute_group *groups[5];
>
> The prior patch needed to have groups[4], every patch much work.
>
> > + if (priv->phy_ops->attr_group)
> > + chip->groups[chip->groups_cnt++] = priv->phy_ops->attr_group;
>
> I am really not excited about having driver specific sysfs
> files.
>
> What is the justification for this?
>
> Jason
Justification: give access to vendor-specific properties that are
specific to a particular chip and its registers.
Andrey
next prev parent reply other threads:[~2016-07-15 3:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 1:51 [PATCH 0/2] tpm: driver- and tpm2-specific sysfs attributes Andrey Pronin
2016-07-15 1:51 ` [PATCH 1/2] tpm: add sysfs attributes for tpm2 Andrey Pronin
2016-07-15 3:21 ` Jason Gunthorpe
2016-07-15 3:32 ` Andrey Pronin
2016-07-15 3:34 ` Jason Gunthorpe
2016-07-15 16:56 ` Andrey Pronin
2016-07-15 17:09 ` Jason Gunthorpe
2016-07-18 19:16 ` Jarkko Sakkinen
2016-07-15 1:51 ` [PATCH 2/2] tpm: support driver-specific sysfs attrs in tpm_tis_core Andrey Pronin
2016-07-15 3:23 ` Jason Gunthorpe
2016-07-15 3:35 ` Andrey Pronin [this message]
2016-07-18 19:20 ` Jarkko Sakkinen
2016-07-18 19:11 ` Jarkko Sakkinen
2016-07-18 19:17 ` Andrey Pronin
2016-07-20 2:51 ` [PATCH v2] tpm: add sysfs attributes for tpm2 Andrey Pronin
2016-07-20 17:05 ` Jason Gunthorpe
2016-07-20 17:41 ` Andrey Pronin
2016-07-28 4:06 ` [PATCH v3] " Andrey Pronin
2016-08-09 10:25 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715033530.GB27104@apronin \
--to=apronin@chromium.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=smbarber@chromium.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).